Skip to content

chore: update dependencies and fix captive portal build#487

Merged
hhvrc merged 5 commits into
developfrom
chore/update-deps-fix-build
Jul 7, 2026
Merged

chore: update dependencies and fix captive portal build#487
hhvrc merged 5 commits into
developfrom
chore/update-deps-fix-build

Conversation

@hhvrc

@hhvrc hhvrc commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Update frontend dependencies (package.json, lockfile, .nvmrc, workspace, svelte-core submodule) and fix @openshock/svelte-core import specifiers that used unexported ./...index.ts subpaths, breaking pnpm run build.

Rewrite imports to the package's exported subpaths:

  • components/ui//index.ts -> ui/
  • components/stepper/index.ts -> stepper
  • components/index.ts -> components
  • typeguards/index.ts -> typeguards
  • state/.svelte.ts -> state/.svelte

Open in Stage

Update frontend dependencies (package.json, lockfile, .nvmrc, workspace,
svelte-core submodule) and fix @openshock/svelte-core import specifiers
that used unexported ./...index.ts subpaths, breaking `pnpm run build`.

Rewrite imports to the package's exported subpaths:
- components/ui/<X>/index.ts -> ui/<X>
- components/stepper/index.ts -> stepper
- components/index.ts        -> components
- typeguards/index.ts        -> typeguards
- state/<X>.svelte.ts        -> state/<X>.svelte
@hhvrc hhvrc self-assigned this Jun 30, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Roadmap Jun 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Change file check

⚠️ Missing — this PR does not add a change file under .changes/.

If this change should show up in the release notes, add one with release-tool new "<title>" --kind <added|changed|deprecated|removed|fixed|security|safety|chore>.

@stage-review

stage-review Bot commented Jun 30, 2026

Copy link
Copy Markdown

Ready to review this PR? Stage has broken it down into 4 individual chapters for you:

Title
1 Update Node.js and package manager versions
2 Update frontend dependencies and workspace configuration
3 Fix svelte-core import specifiers
4 Other changes
Open in Stage

Chapters generated by Stage for commit e45ff5f on Jul 7, 2026 9:30am UTC.

@LucHeart

Copy link
Copy Markdown
Member

but why

@hhvrc

hhvrc commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

but why

why what?
this fixes builds

…rborepo

- Resolve package.json/pnpm-lock.yaml conflicts (take higher dep versions)
- Bump svelte-core submodule to 89d2853 (Frontend's pin; source-based exports)
- Drop Turborepo: remove turbo dependency, consume svelte-core from source
- Keep frontend imports on the components/ui/<X>/index.ts style (matches Frontend)
- build stays plain 'vite build' (no cross-env)

Verified: svelte-check 0 errors, vite build passes.
Copilot AI review requested due to automatic review settings July 7, 2026 09:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the frontend toolchain/dependency set (Node, pnpm, and various frontend devDependencies) and adjusts pnpm workspace/lockfile overrides to keep installs/builds consistent across the workspace.

Changes:

  • Bumped frontend devDependencies (Vite, Tailwind, Svelte tooling, etc.) and refreshed pnpm-lock.yaml.
  • Updated Node/pnpm tooling expectations via frontend/.nvmrc, frontend/package.json engines, and packageManager.
  • Added pnpm overrides for cookie and ts-deepmerge plus minimum-release-age exceptions in pnpm-workspace.yaml.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
frontend/pnpm-workspace.yaml Adds minimum-release-age exclusions and overrides for cookie/ts-deepmerge.
frontend/pnpm-lock.yaml Updates lockfile to reflect new dependency graph and overrides.
frontend/package.json Bumps frontend devDependencies; updates Node/pnpm requirements and package manager pin.
frontend/.nvmrc Updates the pinned Node version used for local development.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread frontend/pnpm-workspace.yaml Outdated
hhvrc added 3 commits July 7, 2026 11:25
f85a2ab resolves directory subpaths for TS/Node consumers, so imports
can reference the package's directory subpaths directly (e.g.
@openshock/svelte-core/components/ui/button) without /index.
@hhvrc hhvrc merged commit d4cc4bc into develop Jul 7, 2026
16 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Roadmap Jul 7, 2026
@hhvrc hhvrc deleted the chore/update-deps-fix-build branch July 7, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants