Make EStopManager Interrupt based by hhvrc · Pull Request #268 · OpenShock/Firmware

hhvrc · 2024-08-21T12:32:35Z

This will lower its response time, reduce cpu load, and prepare this feature for the ESP-IDF conversion

github-actions

Cpp-linter Review

Only 1 out of 6 clang-format concerns fit within this pull request's diff.

Click here for the full clang-format patch

diff --git a/src/VisualStateManager.cpp b/src/VisualStateManager.cpp
index 4aed02a..c668a30 100644
--- a/src/VisualStateManager.cpp
+++ b/src/VisualStateManager.cpp
@@ -149 +149 @@ const PinPatternManager::State kSolidOffPattern[] = {
-template <std::size_t N>
+template<std::size_t N>
@@ -224 +224 @@ void _updateVisualState() {
-  bool rgbActive = s_RGBLedManager != nullptr;
+  bool rgbActive  = s_RGBLedManager != nullptr;
@@ -285 +285 @@ void _handleWiFiScanDone(arduino_event_t* event) {
-#endif // OPENSHOCK_LED_GPIO
+#endif  // OPENSHOCK_LED_GPIO
@@ -288 +288 @@ void _handleWiFiScanDone(arduino_event_t* event) {
-#endif // OPENSHOCK_LED_WS2812B
+#endif  // OPENSHOCK_LED_WS2812B
diff --git a/src/radio/RFTransmitter.cpp b/src/radio/RFTransmitter.cpp
index 80a187d..702b827 100644
--- a/src/radio/RFTransmitter.cpp
+++ b/src/radio/RFTransmitter.cpp
@@ -182,2 +182 @@ void RFTransmitter::TransmitTask(void* arg) {
-    if(OpenShock::EStopManager::IsEStopped()) {
-
+    if (OpenShock::EStopManager::IsEStopped()) {
@@ -208 +207 @@ void RFTransmitter::TransmitTask(void* arg) {
-        if(cmd->until + TRANSMIT_END_DURATION < OpenShock::millis()) {
+        if (cmd->until + TRANSMIT_END_DURATION < OpenShock::millis()) {

Have any feedback or feature suggestions? Share it here.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

outdated suggestion

github-actions

Cpp-linter Review

Only 0 out of 5 clang-format concerns fit within this pull request's diff.

Click here for the full clang-format patch

diff --git a/src/VisualStateManager.cpp b/src/VisualStateManager.cpp
index 4aed02a..c668a30 100644
--- a/src/VisualStateManager.cpp
+++ b/src/VisualStateManager.cpp
@@ -149 +149 @@ const PinPatternManager::State kSolidOffPattern[] = {
-template <std::size_t N>
+template<std::size_t N>
@@ -224 +224 @@ void _updateVisualState() {
-  bool rgbActive = s_RGBLedManager != nullptr;
+  bool rgbActive  = s_RGBLedManager != nullptr;
@@ -285 +285 @@ void _handleWiFiScanDone(arduino_event_t* event) {
-#endif // OPENSHOCK_LED_GPIO
+#endif  // OPENSHOCK_LED_GPIO
@@ -288 +288 @@ void _handleWiFiScanDone(arduino_event_t* event) {
-#endif // OPENSHOCK_LED_WS2812B
+#endif  // OPENSHOCK_LED_WS2812B
diff --git a/src/radio/RFTransmitter.cpp b/src/radio/RFTransmitter.cpp
index f43b77a..702b827 100644
--- a/src/radio/RFTransmitter.cpp
+++ b/src/radio/RFTransmitter.cpp
@@ -207 +207 @@ void RFTransmitter::TransmitTask(void* arg) {
-        if(cmd->until + TRANSMIT_END_DURATION < OpenShock::millis()) {
+        if (cmd->until + TRANSMIT_END_DURATION < OpenShock::millis()) {

Have any feedback or feature suggestions? Share it here.

outdated suggestion

github-actions

Cpp-linter Review

Only 0 out of 5 clang-format concerns fit within this pull request's diff.

Click here for the full clang-format patch

diff --git a/src/VisualStateManager.cpp b/src/VisualStateManager.cpp
index 4aed02a..c668a30 100644
--- a/src/VisualStateManager.cpp
+++ b/src/VisualStateManager.cpp
@@ -149 +149 @@ const PinPatternManager::State kSolidOffPattern[] = {
-template <std::size_t N>
+template<std::size_t N>
@@ -224 +224 @@ void _updateVisualState() {
-  bool rgbActive = s_RGBLedManager != nullptr;
+  bool rgbActive  = s_RGBLedManager != nullptr;
@@ -285 +285 @@ void _handleWiFiScanDone(arduino_event_t* event) {
-#endif // OPENSHOCK_LED_GPIO
+#endif  // OPENSHOCK_LED_GPIO
@@ -288 +288 @@ void _handleWiFiScanDone(arduino_event_t* event) {
-#endif // OPENSHOCK_LED_WS2812B
+#endif  // OPENSHOCK_LED_WS2812B
diff --git a/src/radio/RFTransmitter.cpp b/src/radio/RFTransmitter.cpp
index f43b77a..702b827 100644
--- a/src/radio/RFTransmitter.cpp
+++ b/src/radio/RFTransmitter.cpp
@@ -207 +207 @@ void RFTransmitter::TransmitTask(void* arg) {
-        if(cmd->until + TRANSMIT_END_DURATION < OpenShock::millis()) {
+        if (cmd->until + TRANSMIT_END_DURATION < OpenShock::millis()) {

Have any feedback or feature suggestions? Share it here.

None concern this PR

github-actions

Cpp-linter Review

Only 0 out of 5 clang-format concerns fit within this pull request's diff.

Click here for the full clang-format patch

diff --git a/src/VisualStateManager.cpp b/src/VisualStateManager.cpp
index 91cf5d3..1d729f8 100644
--- a/src/VisualStateManager.cpp
+++ b/src/VisualStateManager.cpp
@@ -149 +149 @@ const PinPatternManager::State kSolidOffPattern[] = {
-template <std::size_t N>
+template<std::size_t N>
@@ -224 +224 @@ void _updateVisualState() {
-  bool rgbActive = s_RGBLedManager != nullptr;
+  bool rgbActive  = s_RGBLedManager != nullptr;
@@ -285 +285 @@ void _handleWiFiScanDone(arduino_event_t* event) {
-#endif // OPENSHOCK_LED_GPIO
+#endif  // OPENSHOCK_LED_GPIO
@@ -288 +288 @@ void _handleWiFiScanDone(arduino_event_t* event) {
-#endif // OPENSHOCK_LED_WS2812B
+#endif  // OPENSHOCK_LED_WS2812B
diff --git a/src/radio/RFTransmitter.cpp b/src/radio/RFTransmitter.cpp
index f43b77a..702b827 100644
--- a/src/radio/RFTransmitter.cpp
+++ b/src/radio/RFTransmitter.cpp
@@ -207 +207 @@ void RFTransmitter::TransmitTask(void* arg) {
-        if(cmd->until + TRANSMIT_END_DURATION < OpenShock::millis()) {
+        if (cmd->until + TRANSMIT_END_DURATION < OpenShock::millis()) {

Have any feedback or feature suggestions? Share it here.

outdated suggestion

github-actions

Cpp-linter Review

Only 0 out of 5 clang-format concerns fit within this pull request's diff.

Click here for the full clang-format patch

diff --git a/src/VisualStateManager.cpp b/src/VisualStateManager.cpp
index 91cf5d3..1d729f8 100644
--- a/src/VisualStateManager.cpp
+++ b/src/VisualStateManager.cpp
@@ -149 +149 @@ const PinPatternManager::State kSolidOffPattern[] = {
-template <std::size_t N>
+template<std::size_t N>
@@ -224 +224 @@ void _updateVisualState() {
-  bool rgbActive = s_RGBLedManager != nullptr;
+  bool rgbActive  = s_RGBLedManager != nullptr;
@@ -285 +285 @@ void _handleWiFiScanDone(arduino_event_t* event) {
-#endif // OPENSHOCK_LED_GPIO
+#endif  // OPENSHOCK_LED_GPIO
@@ -288 +288 @@ void _handleWiFiScanDone(arduino_event_t* event) {
-#endif // OPENSHOCK_LED_WS2812B
+#endif  // OPENSHOCK_LED_WS2812B
diff --git a/src/radio/RFTransmitter.cpp b/src/radio/RFTransmitter.cpp
index f43b77a..702b827 100644
--- a/src/radio/RFTransmitter.cpp
+++ b/src/radio/RFTransmitter.cpp
@@ -207 +207 @@ void RFTransmitter::TransmitTask(void* arg) {
-        if(cmd->until + TRANSMIT_END_DURATION < OpenShock::millis()) {
+        if (cmd->until + TRANSMIT_END_DURATION < OpenShock::millis()) {

Have any feedback or feature suggestions? Share it here.

None concern this PR

nullstalgia

Comments above Task and ISR need to be updated (but that will be done in an upcoming PR), otherwise LGTM.

(Tested on Core V2 hardware)

hhvrc and others added 11 commits August 12, 2024 13:43

WIP

31a13f4

WIP 2 Electric Boogaloo

7fde123

Remove redundant timer

b623e7d

Removing testing constant

ee83584

Remove invalid argument discard

73c6eb2

Move most logic to ISR, minify messages, and simplify logic

1adbcac

Improve error handling

f3a5716

Remove enum usage

a538a9a

Rename patterns

b346c27

fix type conversion error

5591db9

Undo unrelated formatting changes

c23abb1

hhvrc added type: optimization type: enhancement labels Aug 21, 2024

hhvrc added this to the ESP-IDF milestone Aug 21, 2024

hhvrc requested a review from nullstalgia August 21, 2024 12:32

hhvrc self-assigned this Aug 21, 2024

github-actions Bot previously requested changes Aug 21, 2024

View reviewed changes

Comment thread src/radio/RFTransmitter.cpp Outdated

hhvrc and others added 2 commits August 21, 2024 14:39

Fix leftover formatting

9ec58e6

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Merge branch 'develop' into feature/interrupt-based-estop

55d126d

github-actions Bot previously requested changes Aug 21, 2024

View reviewed changes

Fix status led and estop release

7207ecb

github-actions Bot previously requested changes Aug 21, 2024

View reviewed changes

Remove unnecessary logging

63d6813

github-actions Bot previously requested changes Aug 21, 2024

View reviewed changes

nullstalgia approved these changes Aug 21, 2024

View reviewed changes

hhvrc merged commit bfe82c3 into develop Aug 21, 2024

hhvrc deleted the feature/interrupt-based-estop branch August 21, 2024 22:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make EStopManager Interrupt based#268

Make EStopManager Interrupt based#268
hhvrc merged 15 commits into
developfrom
feature/interrupt-based-estop

hhvrc commented Aug 21, 2024

Uh oh!

github-actions Bot left a comment

Uh oh!

Uh oh!

github-actions Bot left a comment

Uh oh!

github-actions Bot left a comment

Uh oh!

github-actions Bot left a comment

Uh oh!

github-actions Bot left a comment

Uh oh!

nullstalgia left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

hhvrc commented Aug 21, 2024

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Uh oh!

nullstalgia left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants