Skip to content

Latex formatting fixed + tests#8

Open
dodekapod wants to merge 1 commit into
mainfrom
fix/latex-support
Open

Latex formatting fixed + tests#8
dodekapod wants to merge 1 commit into
mainfrom
fix/latex-support

Conversation

@dodekapod

Copy link
Copy Markdown
Contributor

Partially fixed #4 .

@dodekapod dodekapod self-assigned this May 26, 2026
Comment thread .github/workflows/test.yml Outdated
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: '22'

@Matteovanypersele Matteovanypersele Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
node-version: '22'
node-version: '20'

Comment thread back/Dockerfile Outdated
Comment on lines +28 to +35
# Copy the frontend output from the first stage
COPY --from=frontend-builder /app/out /app/public

# Copy the backend app code to /app/app
COPY back/app /app/app
COPY back/entrypoint.sh /app/
COPY back/requirements.txt /app/

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Copy the frontend output from the first stage
COPY --from=frontend-builder /app/out /app/public
# Copy the backend app code to /app/app
COPY back/app /app/app
COPY back/entrypoint.sh /app/
COPY back/requirements.txt /app/
# Copy the frontend output from the first stage
COPY --from=frontend-builder /app/out /app/public

@Matteovanypersele Matteovanypersele marked this pull request as ready for review June 3, 2026 14:00

@Matteovanypersele Matteovanypersele left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La correction du rendu LaTeX est nécessaire et bien ciblée (normalisation des délimiteurs, espacement des blocs et retours à la ligne), avec des tests associés couvrant des cas réels. Déployé et validé avec succès.
Le refactor du build Docker en multi-stage est pertinent : un seul build, plus d'image frontend-builder séparée.

J'ai laissé en suggestions 2 points mineurs non bloquant : alignement de la CI sur Node 20 (cohérent avec le Dockerfile) et suppression des COPY redondants dans back/Dockerfile (déjà couverts par COPY back/ .).

Je signale que front/Dockerfile est devenu orphelin depuis le multi-stage et peut être supprimé.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Markdown formatting (incl. latex formulae)

2 participants