Fix prompt-ending --- rendering last line as a bold heading#10
Open
Matteovanypersele wants to merge 1 commit into
Open
Fix prompt-ending --- rendering last line as a bold heading#10Matteovanypersele wants to merge 1 commit into
Matteovanypersele wants to merge 1 commit into
Conversation
3336429 to
4d649bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many prompts end with a line of dashes (
---) used as a courses content delimiter in the dataset templates. In Markdown, a text line immediately followed by---(with no blank line in between) is a setext heading: the dashes act as an underline and turn the previous line into an<h2>. As a result, the last line of those prompts was rendered large/bold instead of plain text.This is standard CommonMark behavior, not a parser bug but it wasn't the intended rendering for these prompts.
Fix
Add
isolateThematicBreaksinPrompt.tsx, called insiderender(). It inserts the missing blank line around lone dash/equals lines, forcing them to render as a horizontal rule (<hr>) instead of underlining the previous line:text\n---→ setext heading (bug)text\n\n---→ horizontal rule (intended)Inline dashes (e.g.
a---b) are untouched, since the setext rule only applies to a line made entirely of dashes. The fix covers every render path.