Security: Potential Memory Leak in Singleton Pattern#1082
Open
tomaioo wants to merge 1 commit into
Open
Conversation
In `GateActorManager.cpp`, the singleton pattern uses raw `new` without a corresponding `delete`, and the destructor is defaulted. The `fInstance` pointer is never deleted, which could lead to memory leaks. While this is a minor issue for a singleton that lives for the program duration, it represents poor memory management practice. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Potential Memory Leak in Singleton Pattern
Problem
Severity:
Low| File:core/opengate_core/opengate_lib/GateActorManager.cpp:L13In
GateActorManager.cpp, the singleton pattern uses rawnewwithout a correspondingdelete, and the destructor is defaulted. ThefInstancepointer is never deleted, which could lead to memory leaks. While this is a minor issue for a singleton that lives for the program duration, it represents poor memory management practice.Solution
Use
std::unique_ptrfor the singleton instance to ensure proper cleanup, or implement a proper destruction mechanism. Consider using the Meyers' singleton pattern for thread-safe initialization without manual memory management.Changes
core/opengate_core/opengate_lib/GateActorManager.cpp(modified)