add support for google service accounts#1682
Conversation
|
Hiya @hunterachieng can you give this pr, I was able to test, GoogleDrive and GoogleSheets adaptor but Gmail adaptor is failing with an error saying |
|
@hunterachieng see my walk through video |
|
@mtuchi I see you mentioned that we have Gmail code, but then you have mentioned that it fails. Should we fix this first or? |
@hunterachieng it's not failing because of the changes, it's failing because of permission, can you spend sometime to figure out the permission we need ? |
… READMEs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
| "type": "object", | ||
| "additionalProperties": true, | ||
| "required": ["access_token"] | ||
| "oneOf": [ |
There was a problem hiding this comment.
I am worried this will break on lightning 🤔
There was a problem hiding this comment.
@josephjclark would love you're input on this, I think lightning is expecting required filed not "oneOf".
Should we have have two different schema maybe 🤷🏽 ? But again lightning need to support both of those schema
|
Hey @hunterachieng when you get sometime please review this pr again for me, I have updated the README.md for updated adaptors |
Summary
Added support for Service Accounts credential type in
gmail,googlesheetsandgoogledriveadaptorRelated
google service-accountsuser guidance on credential page docs#777Details
Service Account credentials requires
private_key,client_email, andscopes. I have modifycreateConnectionfunction to check ifprivate_keyandclient_emailis specified instate.configurationto useJWTauth otherwise we default to useOAuth2auth.Mandatory scopes are currently hardcoded for each adaptor. I used the mandatory scope specified on app when creation OAuth credential for each each adaptor (gmail, googlesheets and googledrive).
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to
know!):
You can read more details in our
Responsible AI Policy
Review Checklist
Before merging, the reviewer should check the following items:
production? Is it safe to release?
dev only changes don't need a changeset.