-
Notifications
You must be signed in to change notification settings - Fork 33
gsheets: Update input data format and allow for multiple range updates #1655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hunterachieng
wants to merge
12
commits into
main
Choose a base branch
from
feature/1476-gsheets-range-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c64ad93
add multi-range support
hunterachieng 2233968
Add changeset
hunterachieng 5e89d3c
fix docs
hunterachieng 1066dd3
fix input and remove callback in getValues
hunterachieng 49de380
fix comments
hunterachieng fd518f7
fix appendValues body
hunterachieng 8248c1d
fix: tests
hunterachieng af3b8cf
fix append values body
hunterachieng ace54dd
fix ast
hunterachieng ae5d435
feat: update docs
hunterachieng ac836aa
feat: build ast
hunterachieng 84a8311
feat: update appendValues signature to use positional range and value…
mtuchi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| --- | ||
| '@openfn/language-googlesheets': major | ||
| --- | ||
|
|
||
| Updated `appendValues()`, `batchUpdateValues()`, and `getValues()` to use positional arguments instead of a single params object. | ||
|
|
||
| ### Migration Guide | ||
|
|
||
| **`appendValues`** | ||
|
|
||
| ```js | ||
| // Before | ||
| appendValues({ | ||
| spreadsheetId: '1abc...', | ||
| range: 'Sheet1!A1:E1', | ||
| values: [['a', 'b']], | ||
| }); | ||
|
|
||
| // Now | ||
| appendValues( | ||
| '1abc...', | ||
| [{ range: 'Sheet1!A1:E1', values: [['a', 'b']] }], | ||
| ); | ||
| ``` | ||
|
|
||
| **`batchUpdateValues`** | ||
|
|
||
| ```js | ||
| // Before | ||
| batchUpdateValues({ | ||
| spreadsheetId: '1abc...', | ||
| range: 'Sheet1!A1', | ||
| values: [['a']], | ||
| valueInputOption: 'RAW', | ||
| }); | ||
|
|
||
| // Now | ||
| batchUpdateValues( | ||
| '1abc...', | ||
| [{ range: 'Sheet1!A1', values: [['a']] }], | ||
| { valueInputOption: 'RAW' } | ||
| ); | ||
| ``` | ||
|
|
||
| Callback parameter has been removed from `appendValues()`, `batchUpdateValues()`, and `getValues()` in favor of a promise-based API. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.