Skip to content

Fix integer division in EV3 motor code #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaartenS11 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix integer division in EV3 motor code #6

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef3bad2
Fix integer division in EV3 motor code
MaartenS11 Dec 9, 2023
04aedc7
Add "f" at the end
MaartenS11 Dec 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions controller/hardware/actuator/motor/ev3-large-motor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ void EV3LargeMotor::forward(int32_t rotation)
return;
}

float speed = m_motor_speed / 1000;
float speed = m_motor_speed / 1000.0;
drive_motor(speed, rotation);
}

Expand All @@ -65,7 +65,7 @@ void EV3LargeMotor::backward(int32_t rotation)
return;
}

float speed = m_motor_speed / 1000;
float speed = m_motor_speed / 1000.0;
drive_motor(-speed, -rotation);
}

Expand Down