fix: reject init() when push is unsupported or script fails to load#207
Merged
Conversation
onesignal-deploy
force-pushed
the
cd_update
branch
from
89fec0d to
556b9d5
Compare
sherwinski
approved these changes
Jun 1, 2026
sherwinski
changed the title
Collaborator
Author
|
🎉 This PR is included in version 3.5.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs the generated wrapper with web-shim-codegen v3.0.8.
This release fixes a bug where
init()would never settle: it now rejects instead of hanging when the browser does not support Web Push or the OneSignal SDK script fails to load. Previously the promise hung forever, which could freeze app startup. Also adds regression tests for both cases.Upstream change: OneSignal/web-shim-codegen#138
Related: OneSignal/onesignal-vue3#83