-
Notifications
You must be signed in to change notification settings - Fork 264
chore: Identity verification rebase on main #1661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nan-li
wants to merge
88
commits into
identity_verification_beta
Choose a base branch
from
identity_verification_rebase_on_5.5.1
base: identity_verification_beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 84 commits
Commits
Show all changes
88 commits
Select commit
Hold shift + click to select a range
fc113d1
chore: add github-to-asana workflows
sherwinski 518cb33
chore: remove old zapier-to-asana workflow
sherwinski df77ee6
chore: prepend full repo name to issue ID, making it more unique
sherwinski dc58e2a
Merge pull request #1577 from OneSignal/github-asana-workflows
sherwinski 256f957
Create class OSCopyOnWriteSet
nan-li 5089ff9
feat(logging): add public log listener methods
nan-li 737cafc
[dev app] add log listener
nan-li 72929df
[tests] add logging tests
nan-li 302e7a1
Merge pull request #1580 from OneSignal/add_log_listener
nan-li 5fb7b7e
nits: fix a decoding type
nan-li b2d84f0
fix to correctly uncache live activity requests
nan-li 4f67d05
tests: add test uncaching live activities requests
nan-li 7d12cc4
Merge pull request #1589 from OneSignal/fix/live_activities_caching
nan-li d907c62
chore: correct file paths in UnitTests
nan-li 9114e1c
chore: correct file paths in OneSignalLiveActivitiesFramework
nan-li b1e43da
chore: correct file paths in OneSignalLiveActivities
nan-li ce432f5
fix mis-calculation of a time interval
nan-li 01ff92f
Add request for Receive Receipts
nan-li 72ae337
Add receive receipts handling
nan-li 701e624
Merge pull request #1591 from OneSignal/chore/fix_folder_paths
nan-li 26f3d84
chore: fix a bug in existing test
nan-li 2a2d695
Add test for live activity receive receipts
nan-li c81982d
To create a new string, don't use localizedDescription
nan-li 73a8eda
Merge pull request #1592 from OneSignal/feat/live_activities_receive_…
nan-li f6027db
Merge pull request #1594 from OneSignal/fix/nserror_localized_descrip…
nan-li 8940453
version bump 5.2.15
nan-li 1d0e25d
chore(ci): Update runner image
nan-li 642f6c5
Release 5.2.15
be27856
Merge pull request #1596 from OneSignal/ci/fix_ci_runner_image_xcode_…
nan-li 47972a4
Merge pull request #1595 from OneSignal/rel/5.2.15
nan-li 1d98760
ci: Update release workflow (#1600)
nan-li e557260
chore: code coverage, add all targets (#1614)
nan-li a380ded
add job to create wrapper prs
fadi-george 69f8c46
for testing action
fadi-george 95af34f
use shared setup git user action
fadi-george ed230a3
Revert "for testing action"
fadi-george 697cdb7
chore(tests): Add in app messaging testing infrastructure and tests (…
nan-li 6a4ce90
Merge pull request #1618 from OneSignal/fg/wrapper-prs
fadi-george 418e25d
forward declarations for Objective-C++ compatibility (#1621)
nan-li f731bc5
fix: Remove exposing var and let macros (#1622)
nan-li 1b0ec4d
fix: NotEqualTo trigger no longer matches non-existent properties (#1…
nan-li 8b7218d
chore(tests): fix flaky badge clearing tests (#1616)
nan-li 7531828
fix: Retry IAM fetch when OneSignal ID becomes available (#1626)
nan-li c2ba503
Feat: live activities click events (#1593)
nan-li 37949ad
chore: fix release actions (#1630)
nan-li 04a1f2c
fix: typo in endpoint and blank out `OSLiveActivityViewExtensions` fo…
nan-li 004150e
chore: Release 5.2.16 (#1631)
github-actions[bot] 48da315
chore: Fix release 5.2.16 (#1632)
nan-li 6be4cf7
fix: use locale-independent formatting for purchase prices (#1634)
nan-li 05c95b5
feat: IAMs now display when triggers added before first fetch (#1635)
nan-li 62bcf4d
feat: merge custom events into main for GA + tests (#1636)
nan-li 41d71a3
chore: Release 5.4.0 (#1637)
github-actions[bot] 9c76be1
"Claude PR Assistant workflow"
sherwinski 6585d0e
"Claude Code Review workflow"
sherwinski 7d2ab05
Merge pull request #1639 from OneSignal/add-claude-github-actions-176…
sherwinski 8af5bc9
chore: fix release action by update runner image (#1638)
nan-li 24c8745
docs: README simplify migration advisory and update links (#1640)
nan-li 1c97103
fix(iam): prevent crash when dismissing IAM during view hierarchy cha…
nan-li 24f8c0a
fix: warning about OSMacros.h in header (#1642)
nan-li cdb9edf
chore: Release 5.4.1 (#1645)
github-actions[bot] 622f35d
chore: rename sdk-actions references to sdk-shared
fadi-george 8ba1239
Merge pull request #1646 from OneSignal/fg/sdk-shared
fadi-george 3092003
chore: Update example app (#1647)
nan-li 666b761
feat: send unattributed sessions to /outcomes/measure (#1648)
nan-li 3832488
fix: badge count not resetting when notifications are cleared (#1649)
nan-li 336fc6e
chore: Release 5.4.2 (#1651)
github-actions[bot] 4c43395
Feat: Add option to disable swizzling (#1650)
nan-li 10961f2
chore: getting started doc for iOS (#1652)
abdulraqeeb33 d21c96d
chore: Release 5.5.0 (#1653)
github-actions[bot] 5f2ad5b
chore: update demo getting started docs and demo UI (#1654)
nan-li 2d460c7
fix: update unattributed outcomes to match attributed outcomes and An…
nan-li eaddea7
chore: Release 5.5.1 (#1658)
github-actions[bot] 58064a3
ci: use GH_PUSH_TOKEN for project workflow
fadi-george faecc92
Merge pull request #1660 from OneSignal/fadi/sdk-4493
fadi-george b7b84d7
Merge remote-tracking branch 'origin/main' into identity_verification…
nan-li 78a9d11
fix: reconcile main's merged code with branch's APIs
nan-li 0a656d8
fix(tests): align IAM tests with branch's no-arg getInAppMessagesFrom…
nan-li 3dac9fe
fix: add OSLoggable conformance to OSCustomEventsExecutor
nan-li 483a92a
fix(custom events): full JWT integration for OSCustomEventsExecutor
nan-li d5850aa
fix tests
nan-li 4904ce4
nit for swiftlint with followup
nan-li 87db3f6
chore: remove unused Asana and Claude workflows
nan-li 9a1e261
chore: remove unused issue response-time workflow
nan-li 3199e90
chore: remove stale Travis config and superseded root files
nan-li fca0943
chore: remove unused workflows and stale CI config (#1662)
nan-li 23516e4
chore: [SDK-4716] revamp iOS examples/demo for cross-SDK parity (#1663)
fadi-george ae58bad
ci: [SDK-4717] add iOS E2E workflow with signing (#1664)
fadi-george 4fce60b
Merge commit '8fb4a0a8^' into identity_verification_rebase_on_5.5.1
nan-li File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| name: Create GitHub Release | ||
|
|
||
| # This workflow creates a GitHub release in iOS-SDK and attaches the built zip files. | ||
| # Runs automatically when a release PR is merged. | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: | ||
| - closed | ||
| branches: | ||
| - main | ||
| - '*-main' # Matches version branches like 5.3-main | ||
|
|
||
| permissions: | ||
| contents: write | ||
| pull-requests: read | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| # Step 1: Extract version from podspec | ||
| get-version: | ||
| if: | | ||
| github.event.pull_request.merged == true && | ||
| contains(github.event.pull_request.title, 'Release') | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| version: ${{ steps.extract_version.outputs.version }} | ||
| steps: | ||
| - name: Checkout OneSignal-iOS-SDK | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ github.event.pull_request.base.ref }} | ||
|
|
||
| - name: Extract release version from podspec | ||
| id: extract_version | ||
| run: | | ||
| VERSION=$(grep -E "s.version\s*=" OneSignal.podspec | sed -E 's/.*"(.*)".*/\1/') | ||
| echo "version=$VERSION" >> $GITHUB_OUTPUT | ||
| echo "Extracted version: $VERSION" | ||
|
|
||
| # Step 2: Use reusable workflow to create GitHub release with release notes | ||
| create-release: | ||
| needs: get-version | ||
| uses: OneSignal/sdk-shared/.github/workflows/github-release.yml@main | ||
| with: | ||
| version: ${{ needs.get-version.outputs.version }} | ||
|
|
||
| # Step 3: Upload the 10 xcframework zips to the release | ||
| upload-assets: | ||
| needs: [get-version, create-release] | ||
| runs-on: ubuntu-latest | ||
|
|
||
| env: | ||
| VERSION: ${{ needs.get-version.outputs.version }} | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| steps: | ||
| - name: Checkout OneSignal-iOS-SDK | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ github.event.pull_request.base.ref }} | ||
|
|
||
| - name: 📋 Display Configuration | ||
| run: | | ||
| echo "============================================" | ||
| echo "📦 Uploading assets for version: $VERSION" | ||
| echo "============================================" | ||
|
|
||
| - name: Upload xcframework zips to release | ||
| run: | | ||
| cd iOS_SDK/OneSignalSDK | ||
|
|
||
| gh release upload "$VERSION" \ | ||
| OneSignal_Core/OneSignalCore.xcframework.zip \ | ||
| OneSignal_Extension/OneSignalExtension.xcframework.zip \ | ||
| OneSignal_XCFramework/OneSignalFramework.xcframework.zip \ | ||
| OneSignal_InAppMessages/OneSignalInAppMessages.xcframework.zip \ | ||
| OneSignal_LiveActivities/OneSignalLiveActivities.xcframework.zip \ | ||
| OneSignal_Location/OneSignalLocation.xcframework.zip \ | ||
| OneSignal_Notifications/OneSignalNotifications.xcframework.zip \ | ||
| OneSignal_OSCore/OneSignalOSCore.xcframework.zip \ | ||
| OneSignal_Outcomes/OneSignalOutcomes.xcframework.zip \ | ||
| OneSignal_User/OneSignalUser.xcframework.zip | ||
|
|
||
| echo "✅ All xcframework zips uploaded successfully!" | ||
| echo "🔗 https://github.com/${{ github.repository }}/releases/tag/$VERSION" |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed in #1600, doesn't exist on
main, replaced with new workflows