Skip to content

Fixes some minor code issues #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daniel-j-h wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Fixes some minor code issues #3

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f176678
Fixes case sensitive includes
daniel-j-h Apr 8, 2016
a8a1680
Puts the CMake build directory on the .gitignore
daniel-j-h Apr 8, 2016
97b527a
std::hash lives in the functional header, fixes compilation
daniel-j-h Apr 8, 2016
2a3abbc
Move for rvalue-ref taking CgStr constructor
daniel-j-h Apr 8, 2016
e09a208
Mark CgStr destructor and move special member functions noexcept
daniel-j-h Apr 8, 2016
a04684d
CgStr does not provide a virtual destructor, mark it final
daniel-j-h Apr 8, 2016
9b8d3c3
Use size-checking equal in equal_to implementation
daniel-j-h Apr 8, 2016
0b78dc4
Mutex is already thread-safe, mark mutable
daniel-j-h Apr 8, 2016
d27a43b
CgTokensHandle final, noexcept
daniel-j-h Apr 8, 2016
c323352
Mark tokens member function const
daniel-j-h Apr 8, 2016
d4eadc8
hardware_concurrency() is allowed to return zero
daniel-j-h Apr 8, 2016
3d93904
Make kMaxRefRecursion TU local
daniel-j-h Apr 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
*.kdev4
build
Copy link
Copy Markdown
Owner

@Oberon00 Oberon00 Apr 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually use out-of-source builds (i.e. I make the build directory a sibling not a child of the project directory), but why not.