Skip to content

Fix 1023 #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Halbaroth wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Fix 1023 #1291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f83c60e
Fix issue 1023
Halbaroth Feb 11, 2025
457e43f
Remove lazy models
Halbaroth Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/lib/reasoners/fun_sat.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ module Make (Th : Theory.S) = struct
guards : guards;
add_inst: E.t -> bool;
unit_facts_cache : (E.gformula * Ex.t) ME.t ref;
last_saved_model : Models.t Lazy.t option ref;
last_saved_model : Models.t option ref;
unknown_reason : Sat_solver_sig.unknown_reason option;

declare_top : Id.typed list ref;
Expand Down Expand Up @@ -1838,8 +1838,7 @@ module Make (Th : Theory.S) = struct
{env with tbox = Th.assume_th_elt env.tbox th_elt dep}

(** returns the latest model stored in the env if any *)
let get_model env =
Option.map Lazy.force !(env.last_saved_model)
let get_model env = !(env.last_saved_model)

let get_unknown_reason env = env.unknown_reason

Expand Down
2 changes: 1 addition & 1 deletion src/lib/reasoners/satml.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ module type SAT_ML = sig
val compute_concrete_model :
declared_ids:Id.typed list ->
t ->
Models.t Lazy.t * Objective.Model.t
Models.t * Objective.Model.t

val set_new_proxies : t -> FF.proxies -> unit

Expand Down
2 changes: 1 addition & 1 deletion src/lib/reasoners/satml.mli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ module type SAT_ML = sig
val compute_concrete_model :
declared_ids:Id.typed list ->
t ->
Models.t Lazy.t * Objective.Model.t
Models.t * Objective.Model.t

val set_new_proxies : t -> Flat_Formula.proxies -> unit

Expand Down
Loading