[18.0][FIX] stock_picking_return_lot: Add domain to the lot_id field so that only the appropriate lots can be selected#2281
Open
victoralmau wants to merge 1 commit into
Conversation
pedrobaeza
reviewed
Mar 18, 2026
…t only the appropriate lots can be selected TT61559
victoralmau
force-pushed
the
18.0-fix-stock_picking_return_lot-TT61559
branch
from
377a296 to
5577a1b
Compare
Comment on lines
+29
to
+33
| smls = rec.move_id.move_line_ids.filtered( | ||
| lambda x: x.state == "done" and x.lot_id | ||
| ) | ||
| domain = [("id", "in", smls.lot_id.ids)] | ||
| rec.lot_id_domain = domain |
There was a problem hiding this comment.
Why is it so restrictive?
The same as my comment here: OCA/rma#554 (comment)
Member
Author
There was a problem hiding this comment.
Similar to what was discussed in the other PR, IMO you should only be able to select lots that have been used; what would be the point of creating a return for a lot that hasn't been used?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add domain to the lot_id field so that only the appropriate lots can be selected
Please @pedrobaeza and @carlos-lopez-tecnativa can you review it?
@Tecnativa TT61559