[18.0][MIG] base_report_to_printer_websocket#457
Open
DavidJForgeFlow wants to merge 4 commits into
Open
Conversation
OCA-git-bot
added
series:18.0
mod:base_report_to_printer_websocket
DavidJForgeFlow
force-pushed
the
18.0-mig-base_report_to_printer_websocket
branch
4 times, most recently
from
8c66c0b to
e4ded07
Compare
miquelalzanillas
suggested changes
May 12, 2026
| class PrintingPrinter(models.Model): | ||
| _inherit = "printing.printer" | ||
|
|
||
| backend = fields.Selection( |
Contributor
There was a problem hiding this comment.
Hello @DavidJForgeFlow
I was thinking to migrate 'base_report_to_printer_qztray' from v19 to v18 as you dou with this module.
My idea was to first create an [IMP] to 'base_report_to_printer' in order to add 'backend' field making the base module to be inheritable for other printing protocols in v18.
I can do it if you confirm that you're agree.
Thanks.
Author
There was a problem hiding this comment.
Yes please do it. I will rebase when done! Thanks!
Contributor
There was a problem hiding this comment.
Hi @DavidJForgeFlow , the IMP has been merged so you can rebase. Thanks.
[IMP] base_report_to_printer_websocket: allow multi_channel [IMP] base_report_to_printer_socket: only show channels to users that have access to them. [FIX] base_report_to_printer_websocket: Use a different way for handling security [IMP] base_report_to_printer_websocket: adapt readme and tests
ArnauCForgeFlow
force-pushed
the
18.0-mig-base_report_to_printer_websocket
branch
from
e4ded07 to
14132e3
Compare
ArnauCForgeFlow
force-pushed
the
18.0-mig-base_report_to_printer_websocket
branch
from
14132e3 to
fa264a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard migration to 18.0
Some adaptations needed as the refactor done in 19.0 to the base module was not done in this version.