[18.0][IMP] product_main_seller: Add main_seller_id to product.product product and add to depends date_start, date_end#3057
Open
Andrii9090-tecnativa wants to merge 1 commit into
Conversation
Contributor
|
Hi @legalsylvain, @quentinDupont, |
pedrobaeza
reviewed
May 7, 2026
| def _compute_main_seller_id(self): | ||
| for product in self: | ||
| if product.variant_seller_ids: | ||
| product.main_seller_id = fields.first( |
Member
There was a problem hiding this comment.
You are missing here the filter for only this variant to have priority.
legalsylvain
suggested changes
May 7, 2026
Contributor
legalsylvain
left a comment
legalsylvain
left a comment
There was a problem hiding this comment.
Hi.
Unfortunately, it is not possible to compute and store fields, based on fields.Date.today() as this value is changing all the time.
Member
|
The idea is to include a cron for updating that daily. @Andrii9090-tecnativa please do it at the same time. |
…uct and add to depends date_start, date_end
Andrii9090-tecnativa
force-pushed
the
18.0-imp-product_main_seller
branch
from
cb42118 to
e35c035
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add field
main_seller_idtoproduct.product@pedrobaeza can you review, please?
@Tecnativa