fix(model_metadata): drop duplicate 'stepfun' entry in _PROVIDER_PREFIXES#65812
Open
waroffchange wants to merge 1 commit into
Open
fix(model_metadata): drop duplicate 'stepfun' entry in _PROVIDER_PREFIXES#65812waroffchange wants to merge 1 commit into
waroffchange wants to merge 1 commit into
Conversation
…IXES "stepfun" is listed twice in the same frozenset literal: once in the canonical provider block and again in the "Common aliases" block. The frozenset dedupes it, so the alias-block copy is dead weight that also misfiles a canonical provider as an alias. Removes the duplicate only; membership is unchanged.
tonydwb
reviewed
Jul 16, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Drops duplicate 'stepfun' entry in _PROVIDER_PREFIXES. Trivial cleanup. No security concerns.
Reviewed by Hermes Agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
"stepfun"is listed twice inside the samefrozensetliteral inagent/model_metadata.py:gemini,zai,minimax,anthropic,deepseek.# Common aliasesblock, alongsideopencode,zen,go,kilo,dashscope.stepfunis a canonical provider name, not an alias, so the second copy is both redundant and filed under the wrong heading.frozensetdedupes on construction, so the alias-block entry has never had any effect — it is dead weight that misleads the next reader into thinkingstepfunis an alias of something.Fix
Removes the duplicate from the alias block. One line, one file.
Why this is behavior-preserving
_PROVIDER_PREFIXESis only ever consumed as a membership test, so a duplicate element is a strict no-op and removing it cannot change any outcome:"stepfun" in _PROVIDER_PREFIXESis stillTrue— line 50 still provides it.No logic, no control flow, and no public surface is touched. The unrelated
api.stepfun.ai/api.stepfun.com→stepfunendpoint-host map further down the file is deliberately left alone.Verification
Provable by reading the literal — the same string appears twice in one
frozenset({...}). Confirmed mechanically with an AST scan of the file (ast.Setelement counting), which reports the frozenset going from 2stepfunentries to 1 while the file's other two occurrences (the endpoint map) stay untouched.