Skip to content

Add splitTestsCompilation solidity setting (1): Configuration updates#8128

Merged
alcuadrado merged 3 commits intodont-split-compilationsfrom
dont-split-compilations-phase-1
Apr 16, 2026
Merged

Add splitTestsCompilation solidity setting (1): Configuration updates#8128
alcuadrado merged 3 commits intodont-split-compilationsfrom
dont-split-compilations-phase-1

Conversation

@alcuadrado
Copy link
Copy Markdown
Member

This PR introduces the new config, it's validation, and resolution

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 12, 2026

⚠️ No Changeset found

Latest commit: be8bf71

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new splitTestsCompilation Solidity setting to Hardhat’s Solidity plugin configuration surface, including user-config type extensions, config schema validation, and resolved-config shaping, with accompanying test updates.

Changes:

  • Extend Solidity config typings to include splitTestsCompilation (user + resolved config).
  • Validate splitTestsCompilation as an optional boolean across supported Solidity config shapes.
  • Resolve splitTestsCompilation into the final solidity config with a default of false, and update tests/fixtures accordingly.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/hardhat/test/internal/builtin-plugins/solidity/config.ts Adds validation + resolution test coverage for splitTestsCompilation, and updates resolved-config test fixture.
packages/hardhat/test/internal/builtin-plugins/solidity/build-system/build-system.ts Updates SolidityConfig test fixture to include required splitTestsCompilation.
packages/hardhat/src/internal/builtin-plugins/solidity/type-extensions.ts Extends CommonSolidityUserConfig and resolved SolidityConfig types with splitTestsCompilation.
packages/hardhat/src/internal/builtin-plugins/solidity/config.ts Adds Zod schema validation for splitTestsCompilation and resolves it into SolidityConfig with default false.

@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-1 branch from ab18c17 to be8bf71 Compare April 13, 2026 09:35
Copy link
Copy Markdown
Member

@schaable schaable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/hardhat/src/internal/builtin-plugins/solidity/config.ts
@alcuadrado alcuadrado merged commit b6fdcac into dont-split-compilations Apr 16, 2026
219 checks passed
@alcuadrado alcuadrado deleted the dont-split-compilations-phase-1 branch April 16, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants