pluto: add elasticsearch to the endpoints to scrape to prometheus#1074
Open
KiaraGrouwstra wants to merge 1 commit into
Open
pluto: add elasticsearch to the endpoints to scrape to prometheus#1074KiaraGrouwstra wants to merge 1 commit into
KiaraGrouwstra wants to merge 1 commit into
Conversation
0d9570b to
2b083dc
Compare
Member
It's a new module, you can always make a backport for those. |
Author
|
Thanks for the suggestion! I filed the backport at NixOS/nixpkgs#529894 now - will update here (whether before or after merge) once that hits. |
2b083dc to
3b8bfc5
Compare
Note that the credentials are technically in the nixos-search repo in plaintext, so mostly using age here for good form. Assisted-by: claude-code:claude-opus-4-8 Signed-off-by: cinereal <cinereal@riseup.net>
3b8bfc5 to
b91d2a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collects diagnostics from the used in nixos-search's Elastic Search instance used in search.nixos.org.
Closes NixOS/nixos-search#1312.
Given diagnostics on this Elastic Search, I hope to get the visibility needed to judge the viability of features like type-ahead or even live filtering search results like nüschtos search does.
On the implementation here, unfortunately the module wasn't in stable yet, so I just had to in-line it here for now.
An additional caveat is use of age here felt like a bit moot given the credential is public for this - but I didn't want to set bad precedent in this repo by starting to just in-line credentials here as well.
Disclaimer: I used a coding agent in the creation of this patch.