Remove all Yul references in EVM placeholder base#46
Conversation
There was a problem hiding this comment.
If we work with solidity code it's better to do simple math opernation unchecked{}. It decreases gas consumption.
Is it important for starKnet?
I think blob-parsing function is good second step in transpiling this to starknet.
Fist one -- simple math operations
There was a problem hiding this comment.
We definitely need something like expmod_static and inversed_static functions in this branch. We cannot run verifier without them. We need to think, what is the best way to do it using pure solidity.
There was a problem hiding this comment.
Need to be tested. Good third step.
There was a problem hiding this comment.
We can create a small test for Merkle trees and try to transpile it to CIAIRO.
It's a good small task, that can be done in a rather short time.
There was a problem hiding this comment.
Good point for another small test.
Changes under should not be merged to master.
This pull request removes all yul asm and re-write sections in pure solidity. It also removes asm code which we no
longer refer. The contents of this branch will be used to transpile to cairo using warp.
There are some outstanding functions which need to be written in cairo
field.solas the current implementations aresolidity hacks and might have a better implemention/library in cairo.
Due to re-writing in solidity , i am experiencing errors on deployment of the contracts due to contract size limitations/estimations going out of bounds. Thus no testing was possible in this step.