Vectors of vectors removed#34
Draft
nkaskov wants to merge 4 commits into
Draft
Conversation
SK0M0R0H
reviewed
Mar 24, 2023
| uint256 []memory xi | ||
| ) internal view returns(bool b){ | ||
| uint256[7] memory precomputed = commitment_calc.eval2_precompute(fri_params.tmp_arr[0], xi[0], xi[1], fri_params.modulus); | ||
| uint256 [4]memory xi |
Member
There was a problem hiding this comment.
Are we sure that this always will be 4? Maybe, it makes sense to set a constant for this
| ); | ||
| z_offset = basic_marshalling.skip_vector_of_uint256_be(blob, z_offset); | ||
|
|
||
| fri_params.batched_U[polynom_index][0] = |
Member
There was a problem hiding this comment.
Is it possible that eval4[0] < 1? Because this one will be re-set again in the next loop
| ); | ||
| unchecked{ point_index++; } | ||
| } | ||
| fri_params.batched_V[polynom_index][0] = |
Member
There was a problem hiding this comment.
The same question about size of eval4[0]
| if (!batched_lpc_verifier.parse_verify_proof_be(blob, proof_map.eval_proof_permutation_offset, | ||
| local_vars.evaluation_points, tr_state, fri_params)) { | ||
| // require(false, "Wrong permutation LPC proof"); | ||
| require(false, "Wrong permutation LPC proof"); |
Member
There was a problem hiding this comment.
In my understanding, we don't need require here because we return false. It's up to the caller check if it's true or false. However, it's not clear how to return the reason of "false" in this case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29.