Skip to content

Fix BNCI2014_001 stimulus timeline metadata#1074

Draft
Copilot wants to merge 4 commits into
developfrom
copilot/fix-bnci2014-001-stimulus-protocol
Draft

Fix BNCI2014_001 stimulus timeline metadata#1074
Copilot wants to merge 4 commits into
developfrom
copilot/fix-bnci2014-001-stimulus-protocol

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 20, 2026

The generated BNCI2014_001 stimulus protocol figure showed an incorrect 2s fixation + 2s motor imagery timeline. The source protocol is 2s fixation, 1.25s cue, and motor imagery through t=6s.

  • BNCI2014_001 metadata

    • Added explicit stimulus timing for cross onset, cue onset, and trial duration.
    • Corrected cue_duration_s from 4.0 to 1.25.
  • Timeline extraction

    • Updated motor-imagery timeline generation to represent protocols where imagery starts at cue onset and overlaps with the cue.
  • Regression coverage

    • Added a focused test asserting the generated BNCI2014_001 timeline phases.
assert [(p.label, p.onset_s, p.duration_s) for p in timeline.phases] == [
    ("Fixation +", 0.0, 2.0),
    ("Cue + MI", 2.0, 1.25),
    ("Motor Imagery", 3.25, 2.75),
]

Copilot AI and others added 2 commits May 20, 2026 12:09
Agent-Logs-Url: https://github.com/NeuroTechX/moabb/sessions/43729bfe-3d86-49d4-afa9-dac038b40e33

Co-authored-by: bruAristimunha <42702466+bruAristimunha@users.noreply.github.com>
Agent-Logs-Url: https://github.com/NeuroTechX/moabb/sessions/43729bfe-3d86-49d4-afa9-dac038b40e33

Co-authored-by: bruAristimunha <42702466+bruAristimunha@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix stimulus protocol for BNCI2014_001 documentation Fix BNCI2014_001 stimulus timeline metadata May 20, 2026
Copilot AI requested a review from bruAristimunha May 20, 2026 12:13
@bruAristimunha
Copy link
Copy Markdown
Collaborator

fix the pre-commit and the what's new, put me as author @copilot

Agent-Logs-Url: https://github.com/NeuroTechX/moabb/sessions/67fa9242-9a37-408c-8bdf-efac12b8517c

Co-authored-by: bruAristimunha <42702466+bruAristimunha@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 20, 2026

fix the pre-commit and the what's new, put me as author @copilot

Addressed in 7aca3e3: ran/fixed pre-commit formatting and added the What's new bug entry attributed to Bruno Aristimunha_. Validation passed with pre-commit, targeted tests, Code Review, and CodeQL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect stimulus protocol BNCI2014_001

2 participants