Skip to content

fix(l1): bound startup RPC calls with per-call timeouts#3676

Merged
rodrodros merged 2 commits into
mainfrom
rdr/invalid-url-fix
May 26, 2026
Merged

fix(l1): bound startup RPC calls with per-call timeouts#3676
rodrodros merged 2 commits into
mainfrom
rdr/invalid-url-fix

Conversation

@rodrodros
Copy link
Copy Markdown
Contributor

@rodrodros rodrodros commented May 25, 2026

Adding context deadlines to the interactions with the L1 to avoid node stalling for ever

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026

Codecov Report

❌ Patch coverage is 94.33962% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.32%. Comparing base (345d918) to head (0ffcd0d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
l1/l1.go 96.15% 2 Missing ⚠️
node/migration.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3676      +/-   ##
==========================================
+ Coverage   76.29%   76.32%   +0.02%     
==========================================
  Files         396      396              
  Lines       36537    36579      +42     
==========================================
+ Hits        27877    27918      +41     
- Misses       6683     6686       +3     
+ Partials     1977     1975       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@RafaelGranza RafaelGranza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I adde a small PR description for future clarity.
The title covers the what but not the why.

Also, I left a few nits.

Comment thread node/migration.go Outdated
Comment thread l1/l1.go
Comment thread l1/l1.go
@rodrodros rodrodros enabled auto-merge (squash) May 26, 2026 09:34
@rodrodros rodrodros merged commit e27e9f5 into main May 26, 2026
27 checks passed
@rodrodros rodrodros deleted the rdr/invalid-url-fix branch May 26, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants