feat(consensus): implement propeller#3636
Open
rodrodros wants to merge 40 commits into
Open
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fix(consensus/propeller): shceduler.go minor improvs
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (23.67%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3636 +/- ##
==========================================
- Coverage 77.20% 74.43% -2.77%
==========================================
Files 388 402 +14
Lines 35110 36266 +1156
==========================================
- Hits 27106 26996 -110
- Misses 6043 7395 +1352
+ Partials 1961 1875 -86 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements Propeller. All the main components have been implemented. What's missing is adding tests for them as well as integrating it into the consensus engine.
Due to Starknet not wanting to descentralize to a bigger number than 10 for now, Propeller is no longer relevant in the near future (aimed at 200 users) and Gossipsub is good enough for a small descentralized count.
We will merge the code and bring it up later if it is back on the table