Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,11 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v6
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 #v7.0.0

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v2
uses: github/codeql-action/init@8aad20d150bbac5944a9f9d289da16a4b0d87c1e #v4.36.2
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
Expand All @@ -58,7 +58,7 @@ jobs:
# Autobuild attempts to build any compiled languages (C/C++, C#, Go, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@v2
uses: github/codeql-action/autobuild@8aad20d150bbac5944a9f9d289da16a4b0d87c1e #v4.36.2

# ℹ️ Command-line programs to run using the OS shell.
# 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
Expand All @@ -71,6 +71,6 @@ jobs:
# ./location_of_script_within_repo/buildscript.sh

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2
uses: github/codeql-action/analyze@8aad20d150bbac5944a9f9d289da16a4b0d87c1e #v4.36.2
with:
category: "/language:${{matrix.language}}"
2 changes: 1 addition & 1 deletion .github/workflows/full-stack-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:

steps:
- name: Check out source
uses: actions/checkout@v6
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 #v7.0.0

- name: Install Metaflow
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/metaflow.s3_tests.minio.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ jobs:
METAFLOW_S3_TRANSIENT_RETRY_COUNT: "7"

steps:
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 #v7.0.0
with:
ref: refs/pull/${{ github.event.pull_request.number }}/merge
submodules: recursive
- name: Set up Python
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 #v6.2.0
with:
python-version: ${{ matrix.ver }}
- name: Install dependencies
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ jobs:
# IMPORTANT: this permission is mandatory for Trusted Publishing
id-token: write
steps:
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 #v7.0.0
- name: Set up Python 3.x
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 #v6.2.0
with:
python-version: '3.x'
- name: Install Python 3.x dependencies
Expand All @@ -36,8 +36,8 @@ jobs:
run: |
cd ./stubs && python3 setup.py sdist bdist_wheel --universal && cd -
- name: Publish metaflow-stubs package
uses: pypa/gh-action-pypi-publish@ed0c53931b1dc9bd32cbe73a98c7f6766f8a527e #v1.13.0
uses: pypa/gh-action-pypi-publish@cef221092ed1bacb1cc03d23a2d87d1d172e277b #v1.14.0
with:
packages-dir: ./stubs/dist
- name: Publish metaflow package
uses: pypa/gh-action-pypi-publish@ed0c53931b1dc9bd32cbe73a98c7f6766f8a527e #v1.13.0
uses: pypa/gh-action-pypi-publish@cef221092ed1bacb1cc03d23a2d87d1d172e277b #v1.14.0
4 changes: 2 additions & 2 deletions .github/workflows/test-card-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ jobs:
run:
working-directory: ./metaflow/plugins/cards/ui
steps:
- uses: actions/checkout@v6
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 #v7.0.0
- name: Use Node.js
uses: actions/setup-node@v6
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e #v6.4.0
with:
node-version: '20.x'
- name: Run npm audit
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test-stubs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ jobs:
ver: "3.10"

steps:
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 #v7.0.0

- name: Set up Python
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 #v6.2.0
with:
python-version: ${{ matrix.ver }}

Expand Down Expand Up @@ -65,7 +65,7 @@ jobs:
fi

- name: Run mypy tests
uses: nick-fields/retry@v2
uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 #v4.0.0
with:
max_attempts: 2
timeout_minutes: 3
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ jobs:
pre-commit:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 #v7.0.0
- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
- uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # v3.0.1
- uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd #v3.0.1

Python:
name: core / Python ${{ matrix.ver }} on ${{ matrix.os }}
Expand All @@ -39,10 +39,10 @@ jobs:
ver: "3.10"

steps:
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 #v7.0.0

- name: Set up Python
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 #v6.2.0
with:
python-version: ${{ matrix.ver }}
env:
Expand Down
64 changes: 32 additions & 32 deletions .github/workflows/ux-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,15 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 #v7.0.0

- name: Set up Python 3.9
uses: actions/setup-python@v5
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 #v6.2.0
with:
python-version: "3.9"

- name: Cache pip packages
uses: actions/cache@v4
uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae #v5.0.5
with:
path: ~/.cache/pip
key: pip-py3.9-${{ hashFiles('setup.py', 'setup.cfg') }}
Expand All @@ -69,7 +69,7 @@ jobs:

- name: Upload coverage data
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a #v7.0.1
with:
name: coverage-unit
path: |
Expand All @@ -80,7 +80,7 @@ jobs:

- name: Upload test results
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a #v7.0.1
with:
name: junit-unit
path: junit-unit.xml
Expand All @@ -89,7 +89,7 @@ jobs:
- name: Publish test results
if: always()
continue-on-error: true
uses: dorny/test-reporter@d61b558e8df85cb60d09ca3e5b09653b4477cea7 # v1
uses: dorny/test-reporter@a43b3a5f7366b97d083190328d2c652e1a8b6aa2 #v3.0.0
with:
name: "Test Results — Unit"
path: junit-unit.xml
Expand All @@ -101,10 +101,10 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 #v7.0.0

- name: Set up Python 3.10
uses: actions/setup-python@v5
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 #v6.2.0
with:
python-version: "3.10"

Expand All @@ -120,7 +120,7 @@ jobs:
tox -e spin -- --junit-xml=junit-spin.xml --cov=metaflow --cov-report=xml:coverage.xml --cov-branch
- name: Upload coverage data
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a #v7.0.1
with:
name: coverage-spin
path: |
Expand All @@ -130,7 +130,7 @@ jobs:
include-hidden-files: true
- name: Upload test results
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a #v7.0.1
with:
name: junit-spin
path: junit-spin.xml
Expand All @@ -139,7 +139,7 @@ jobs:
- name: Publish test results
if: always()
continue-on-error: true
uses: dorny/test-reporter@d61b558e8df85cb60d09ca3e5b09653b4477cea7 # v1
uses: dorny/test-reporter@a43b3a5f7366b97d083190328d2c652e1a8b6aa2 #v3.0.0
with:
name: "Test Results — Spin"
path: junit-spin.xml
Expand Down Expand Up @@ -176,10 +176,10 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 #v7.0.0

- name: Free disk space
uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be # v1.3.1
uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be #v1.3.1
with:
tool-cache: false
android: true
Expand All @@ -190,12 +190,12 @@ jobs:
swap-storage: false

- name: Set up Python 3.9
uses: actions/setup-python@v5
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 #v6.2.0
with:
python-version: "3.9"

- name: Cache pip packages
uses: actions/cache@v4
uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae #v5.0.5
with:
path: ~/.cache/pip
key: pip-py3.9-${{ hashFiles('setup.py', 'setup.cfg') }}
Expand All @@ -207,15 +207,15 @@ jobs:
pip install -e ".[dev]"

- name: Set up minikube
uses: medyagh/setup-minikube@aba8d5ff1666d19b9549133e3b92e70d4fc52cb7
uses: medyagh/setup-minikube@e9e035a86bbc3caea26a450bd4dbf9d0c453682e #v0.0.21
with:
driver: docker
cpus: 2
memory: ${{ matrix.memory }}

- name: Restore minikube image cache
id: image-cache
uses: actions/cache/restore@v4
uses: actions/cache/restore@27d5ce7f107fe9357f9df03efb73ab90386fccae #v5.0.5
with:
path: /tmp/minikube-image-cache
key: minikube-images-${{ matrix.backend }}-${{ hashFiles('devtools/Tiltfile') }}
Expand All @@ -226,7 +226,7 @@ jobs:
run: devtools/ci/load-minikube-images.sh

- name: Cache Helm repos and charts
uses: actions/cache@v4
uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae #v5.0.5
with:
path: |
~/.cache/helm
Expand All @@ -237,11 +237,11 @@ jobs:
helm-charts-

- name: Set up Helm
uses: azure/setup-helm@v4
uses: azure/setup-helm@dda3372f752e03dde6b3237bc9431cdc2f7a02a2 #v5.0.0

- name: Cache Tilt binary
id: tilt-cache
uses: actions/cache@v4
uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae #v5.0.5
with:
path: /usr/local/bin/tilt
key: tilt-v0.33.11
Expand Down Expand Up @@ -290,7 +290,7 @@ jobs:

- name: Store minikube image cache
if: steps.image-cache.outputs.cache-hit != 'true'
uses: actions/cache/save@v4
uses: actions/cache/save@27d5ce7f107fe9357f9df03efb73ab90386fccae #v5.0.5
with:
path: /tmp/minikube-image-cache
key: minikube-images-${{ matrix.backend }}-${{ hashFiles('devtools/Tiltfile') }}
Expand Down Expand Up @@ -342,7 +342,7 @@ jobs:

- name: Upload coverage data
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a #v7.0.1
with:
name: coverage-${{ matrix.backend }}
path: |
Expand All @@ -354,7 +354,7 @@ jobs:

- name: Upload test results
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a #v7.0.1
with:
name: junit-${{ matrix.backend }}
path: junit-${{ matrix.backend }}.xml
Expand All @@ -363,7 +363,7 @@ jobs:
- name: Publish test results
if: always()
continue-on-error: true
uses: dorny/test-reporter@d61b558e8df85cb60d09ca3e5b09653b4477cea7 # v1
uses: dorny/test-reporter@a43b3a5f7366b97d083190328d2c652e1a8b6aa2 #v3.0.0
with:
name: "Test Results — ${{ matrix.backend }}"
path: junit-${{ matrix.backend }}.xml
Expand All @@ -384,7 +384,7 @@ jobs:

- name: Upload Tilt logs
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a #v7.0.1
with:
name: tilt-logs-${{ matrix.backend }}
path: /tmp/tilt.log
Expand All @@ -397,31 +397,31 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 #v7.0.0

- name: Set up Python 3.9
uses: actions/setup-python@v5
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 #v6.2.0
with:
python-version: "3.9"

- name: Install coverage
run: pip install coverage[toml]

- name: Download coverage data from all backends
uses: actions/download-artifact@v4
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c #v8.0.1
with:
pattern: coverage-*
path: coverage-artifacts/

- name: Download test results from all backends
uses: actions/download-artifact@v4
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c #v8.0.1
Comment on lines +411 to +417

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 upload-artifact and download-artifact major version mismatch

Artifacts are uploaded with upload-artifact@v7.0.1 but downloaded with download-artifact@v8.0.1. GitHub has historically required these two actions to use the same major version (the v3→v4 migration, for example, required upgrading both simultaneously because the storage format changed). If the artifact schema changed between v7 and v8, the download-artifact step in the coverage-report job will fail to find or decode the artifacts produced by the earlier jobs, silently breaking coverage reporting.

with:
pattern: junit-*
path: junit-artifacts/

- name: Publish combined test results
continue-on-error: true
uses: dorny/test-reporter@d61b558e8df85cb60d09ca3e5b09653b4477cea7 # v1
uses: dorny/test-reporter@a43b3a5f7366b97d083190328d2c652e1a8b6aa2 #v3.0.0
with:
name: "Test Results — All Backends"
path: "junit-artifacts/**/*.xml"
Expand All @@ -447,14 +447,14 @@ jobs:
echo "**Total coverage: $total**" >> $GITHUB_STEP_SUMMARY

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v5
uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f #v7.0.0
with:
token: ${{ secrets.CODECOV_TOKEN }}
files: combined-coverage.xml
name: ux-combined

- name: Upload combined coverage report
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a #v7.0.1
with:
name: coverage-combined
path: |
Expand Down
Loading