Skip to content

fix(client): give specific error for blank/whitespace pathspec components #3261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dheerenmohta wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Open

fix(client): give specific error for blank/whitespace pathspec components #3261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions metaflow/client/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,16 @@ def __init__(
if pathspec and _object is None:
ids = pathspec.split("/")

# Reject blank components (empty string or whitespace-only), e.g. "Flow//Step"
# or "Flow/ /Step". Check before the length tests so the error is specific.
blank = [i for i, c in enumerate(ids) if not c.strip()]
if blank:
raise MetaflowInvalidPathspec(
"Pathspec '%s' has an empty or blank component at position(s) %s. "
"Each '/' must separate non-empty path parts."
% (pathspec, ", ".join(str(p) for p in blank))
)
Comment on lines +328 to +332

@greptile-apps greptile-apps Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The positions are reported as 0-based indices, but end-users mentally count path components from 1 (e.g., "Flow/ /Step" — component 2 is blank, not component 1). Using 1-based positions in the error message would be more intuitive here.

Suggested change
raise MetaflowInvalidPathspec(
"Pathspec '%s' has an empty or blank component at position(s) %s. "
"Each '/' must separate non-empty path parts."
% (pathspec, ", ".join(str(p) for p in blank))
)
raise MetaflowInvalidPathspec(
"Pathspec '%s' has an empty or blank component at position(s) %s. "
"Each '/' must separate non-empty path parts."
% (pathspec, ", ".join(str(p + 1) for p in blank))
)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!


if self._NAME == "flow" and len(ids) != 1:
raise MetaflowInvalidPathspec("Expects Flow('FlowName')")
elif self._NAME == "run" and len(ids) != 2:
Expand Down
Loading