refactor!: Remove module amounts#262
Merged
jan-ferdinand merged 1 commit intomasterfrom Jun 17, 2025
Merged
Conversation
The (only) type of module `amounts`, namely `U32s`, is not used anywhere in this crate nor in any of its dependencies.
jan-ferdinand
force-pushed
the
jfs/remove_amounts
branch
from
2f58528 to
a5cbc60
Compare
Sword-Smith
approved these changes
Jun 17, 2025
Member
Sword-Smith
left a comment
Sword-Smith
left a comment
There was a problem hiding this comment.
Yeah. Doesn't seem to be used in either lib or neptune-core anymore. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The (only) type of module
amounts, namelyU32s, is not used anywhere in this crate nor in any of its dependencies.