Skip to content

fix: cross-platform default output path tests for CI #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ne9roni merged 1 commit into from
Apr 19, 2026
Merged

fix: cross-platform default output path tests for CI #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions tests/output-paths.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { resolve } from "node:path";

import { describe, expect, test } from "vitest";

import {
Expand All @@ -6,31 +8,34 @@ import {
getDefaultProjectPath,
} from "../src/cli/output-paths.js";

/** Absolute cwd fixture — avoid Windows-style roots on POSIX (they resolve relative to cwd). */
const fixtureCwd = resolve("/workspace");

describe("default output paths", () => {
test("project create defaults to output/output.piskel in cwd", () => {
expect(getDefaultProjectPath("C:/workspace")).toBe(
"C:\\workspace\\output\\output.piskel",
expect(getDefaultProjectPath(fixtureCwd)).toBe(
resolve(fixtureCwd, "output", "output.piskel"),
);
});

test("export commands default to output/output.* in cwd", () => {
expect(getDefaultExportPath("C:/workspace", "png")).toBe(
"C:\\workspace\\output\\output.png",
Copy link
Copy Markdown

@cursor cursor Bot Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are tautological — expected values mirror production logic

Low Severity

Every assertion now computes its expected value with resolve(fixtureCwd, "output", …), which is identical to the implementation in getDefaultProjectPath / getDefaultExportPath / getDefaultExportFramesDir. The tests effectively assert resolve(x, "output", "output.piskel") === resolve(x, "output", "output.piskel"), meaning a regression in the production code's path structure (e.g., changing the resolve call to join, or altering separator behavior) would never be caught. Using a platform-aware but independently constructed expected string (e.g. fixtureCwd + "/output/output.piskel" on POSIX) would keep the cross-platform fix while preserving the test's ability to detect real bugs.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 1978990. Configure here.

expect(getDefaultExportPath(fixtureCwd, "png")).toBe(
resolve(fixtureCwd, "output", "output.png"),
);
expect(getDefaultExportPath("C:/workspace", "gif")).toBe(
"C:\\workspace\\output\\output.gif",
expect(getDefaultExportPath(fixtureCwd, "gif")).toBe(
resolve(fixtureCwd, "output", "output.gif"),
);
expect(getDefaultExportPath("C:/workspace", "spritesheet")).toBe(
"C:\\workspace\\output\\output.png",
expect(getDefaultExportPath(fixtureCwd, "spritesheet")).toBe(
resolve(fixtureCwd, "output", "output.png"),
);
expect(getDefaultExportPath("C:/workspace", "metadata")).toBe(
"C:\\workspace\\output\\output.json",
expect(getDefaultExportPath(fixtureCwd, "metadata")).toBe(
resolve(fixtureCwd, "output", "output.json"),
);
});

test("export frames defaults to output/frames in cwd", () => {
expect(getDefaultExportFramesDir("C:/workspace")).toBe(
"C:\\workspace\\output\\frames",
expect(getDefaultExportFramesDir(fixtureCwd)).toBe(
resolve(fixtureCwd, "output", "frames"),
);
});
});
Loading