[react-pdf] text layer와 canvas 위치 불일치 수정#221
Open
2-one-week wants to merge 2 commits into
Open
Conversation
- CSS: line-height: 1, text-size-adjust: none 추가 (pdfjs-dist 공식 구현 기준) - CSS: transform-origin을 0% 0%로 변경 - merge: text item 간 gap을 width에 포함하여 visual span 정확도 개선 - tokenize: 매직 넘버(+5, +3.5, 4.5) 제거, 비례 분할 방식으로 변경 Closes common-fe/pie/discussions/3483 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, push a new commit or reopen this pull request to trigger a review.
Collaborator
✅ Changeset detectedLatest commit: 08036d1
If no version change is needed, please add The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
|
Fixes the mismatch between the text layer and canvas in react-pdf.
Member
Author
|
/canary-publish |
Collaborator
NPM Packages📦 @naverpay/react-pdfTotal Sizes: 20.9 kB Total Changes: +17 B (0%) ℹ️ View Unchanged Files
powered by: naverpay size-action |
Collaborator
Published Canary Packages |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Describe your changes
Request