fix bug where deleting an api backend returned an undefined error#714
Open
jtmkrueger wants to merge 1 commit into
Open
fix bug where deleting an api backend returned an undefined error#714jtmkrueger wants to merge 1 commit into
jtmkrueger wants to merge 1 commit into
Conversation
what seemed to be happening was that ember kept trying to observe an api backend that had been deleted and no longer had data. This transitions away from that view first, so that it doesn't fall into that trap anymore.
jtmkrueger
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves 18F/api.data.gov#703
What seemed to be happening was that ember kept trying to observe an api back end that had been deleted and no longer had data. This transitions away from that view first, so that it doesn't fall into that trap anymore. This does change the flow a bit, but It seemed a bit off to be still on the page for the back end you'd just deleted so this rectifies that.
I also added a couple tests to prove this out!