feat(tracing): auto-detect git information - #48
Merged
Conversation
Closes #38 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
|
Do we really need this? Does it add value? |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
|
I think this does add value - knowing the deployed commit hash and branch when an error occurs is useful for debugging. I've simplified the implementation by replacing the raw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnvironmentCollectorusingproc_openwith a 1-second timeoutGitInfoDetectorclass with static caching so git commands run only once per processconfig('app.git_commit')still works as an override forgit_hashgittoggle undertracingconfig (default:true)git_commitkey is preserved in environment dataCloses #38
Test plan
config('app.git_commit')override takes precedence over auto-detected hashtracing.gitconfig isfalsegit_commitbackward-compatible key is set fromgit_hashGitInfoDetectorintegration tests verify real git commands work🤖 Generated with Claude Code