Skip to content

Remove some unused(?!) methods on contest_relation #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bagedevimo wants to merge 1 commit into
base: migration-version
Choose a base branch
from
Open

Remove some unused(?!) methods on contest_relation #315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/models/contest_relation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,16 +67,16 @@ def contest_id=(contest_id)
update_finish_at
end

def contest_with_update=(contest)
self.contest_without_update = (contest)
def contest=(contest)
super
update_finish_at
end

def extra_time=(extra_time)
self[:extra_time] = extra_time
update_finish_at
end
alias_method_chain :contest=, :update

def update_finish_at
self.finish_at = [contest.end_time, started_at.advance(hours: contest.duration.to_f)].min.advance(seconds: extra_time) unless contest.nil? || started_at.nil?
end
Expand Down