Add libnvidia-nvvm70.so library to CDI spec#1876
Open
cdesiniotis wants to merge 1 commit into
Open
Conversation
fixes NVIDIA#1875 Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
Coverage Report for CI Build 27309155390Coverage increased (+0.06%) to 43.597%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
cdesiniotis
commented
Jun 10, 2026
|
|
||
| libraries := discover.Merge( | ||
| versionSuffixLibraryMounts, | ||
| legacyNVVMLibraryMounts, |
Contributor
Author
There was a problem hiding this comment.
I initially added libnvidia-nvvm70.so to getExplicitDriverLibraryMounts() (which was a one line change), but I noticed that the explicit driver libraries only get added if one opts-in to the enable-explicit-driver-libraries feature flag (this behavior was introduced in 5a3dcbe).
Contributor
Author
There was a problem hiding this comment.
@elezar in the commit message for 5a3dcbe you mention:
Instead of always injecting the list of explict libraries, we
switch these to opt-in instead. This means that they can be
generated in use cases such as GKE where they are expected,
but don't affect other use cases where they are not.
Do you recall what use cases were affected by having the explicit driver libraries mounted by default? I am curious as to why this was made an opt-in to begin with.
tariq1890
approved these changes
Jun 10, 2026
tariq1890
reviewed
Jun 10, 2026
| } | ||
| legacyNVVMLibraryMounts, err := l.getLegacyNVVMLibraryMounts() | ||
| if err != nil { | ||
| return nil, err |
Contributor
There was a problem hiding this comment.
nit: can you wrap the error here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1875
Testing