Skip to content

Add libnvidia-nvvm70.so library to CDI spec#1876

Open
cdesiniotis wants to merge 1 commit into
NVIDIA:mainfrom
cdesiniotis:add-nvvm70-so
Open

Add libnvidia-nvvm70.so library to CDI spec#1876
cdesiniotis wants to merge 1 commit into
NVIDIA:mainfrom
cdesiniotis:add-nvvm70-so

Conversation

@cdesiniotis

Copy link
Copy Markdown
Contributor

fixes #1875

Testing

$ ls -ltr /usr/lib/x86_64-linux-gnu/libnvidia-nvvm*
-rw-r--r-- 1 root root 24829456 Dec  8  2025 /usr/lib/x86_64-linux-gnu/libnvidia-nvvm70.so.4
-rw-r--r-- 1 root root 78117032 Dec  8  2025 /usr/lib/x86_64-linux-gnu/libnvidia-nvvm.so.590.48.01
lrwxrwxrwx 1 root root       27 Dec  8  2025 /usr/lib/x86_64-linux-gnu/libnvidia-nvvm.so.4 -> libnvidia-nvvm.so.590.48.01

$ ./nvidia-ctk --version
NVIDIA Container Toolkit CLI version 1.20.0-dev
commit: d8d7fecdc5d83b8b897188c0bd1f2c4bae5220bb-dirty

$ ./nvidia-ctk cdi generate --output ./nvidia.yaml 2>/dev/null

$ grep -A6 "libnvidia-nvvm70" nvidia.yaml
        - hostPath: /usr/lib/x86_64-linux-gnu/libnvidia-nvvm70.so.4
          containerPath: /usr/lib/x86_64-linux-gnu/libnvidia-nvvm70.so.4
          options:
            - ro
            - nosuid
            - nodev
            - rbind
            - rprivate

$ grep -A6 "libnvidia-nvvm.so.590.48.01$" nvidia.yaml
        - hostPath: /usr/lib/x86_64-linux-gnu/libnvidia-nvvm.so.590.48.01
          containerPath: /usr/lib/x86_64-linux-gnu/libnvidia-nvvm.so.590.48.01
          options:
            - ro
            - nosuid
            - nodev
            - rbind
            - rprivate

fixes NVIDIA#1875

Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
@cdesiniotis cdesiniotis requested a review from tariq1890 June 10, 2026 22:00
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 27309155390

Coverage increased (+0.06%) to 43.597%

Details

  • Coverage increased (+0.06%) from the base build.
  • Patch coverage: 4 uncovered changes across 1 file (18 of 22 lines covered, 81.82%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
pkg/nvcdi/driver-nvml.go 22 18 81.82%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 15031
Covered Lines: 6553
Line Coverage: 43.6%
Coverage Strength: 0.48 hits per line

💛 - Coveralls

Comment thread pkg/nvcdi/driver-nvml.go

libraries := discover.Merge(
versionSuffixLibraryMounts,
legacyNVVMLibraryMounts,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially added libnvidia-nvvm70.so to getExplicitDriverLibraryMounts() (which was a one line change), but I noticed that the explicit driver libraries only get added if one opts-in to the enable-explicit-driver-libraries feature flag (this behavior was introduced in 5a3dcbe).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elezar in the commit message for 5a3dcbe you mention:

Instead of always injecting the list of explict libraries, we
switch these to opt-in instead. This means that they can be
generated in use cases such as GKE where they are expected,
but don't affect other use cases where they are not.

Do you recall what use cases were affected by having the explicit driver libraries mounted by default? I am curious as to why this was made an opt-in to begin with.

Comment thread pkg/nvcdi/driver-nvml.go
}
legacyNVVMLibraryMounts, err := l.getLegacyNVVMLibraryMounts()
if err != nil {
return nil, err

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you wrap the error here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: libnvidia-nvvm70.so missing from generated CDI spec

3 participants