feat(metrics): enable RETIRED_SBE and RETIRED_DBE counters by default#666
Open
75asu wants to merge 1 commit into
Open
feat(metrics): enable RETIRED_SBE and RETIRED_DBE counters by default#66675asu wants to merge 1 commit into
75asu wants to merge 1 commit into
Conversation
Signed-off-by: Asutosh Panda <asutosh.pda@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #646
DCGM_FI_DEV_RETIRED_SBEandDCGM_FI_DEV_RETIRED_DBEinetc/dcp-metrics-included.csv,etc/default-counters.csv, andtests/integration/testdata/default-counters.csv.c6a7730b, 2021-02-25) shows these lines were inherited as commented-out defaults rather than deliberately disabled. No Go code references them, so the generic CSV-loaded counter path is sufficient.DCGM_FI_DEV_RETIRED_PENDING(adjacent line) left commented -- not requested in the issue, avoiding scope creep.DCGM_FI_DEV_XID_ERRORSas missing, but that metric is already enabled by default indefault-counters.csvand has dedicated handling ininternal/pkg/collector/xid_collector.go. If a user isn't seeing it, that's likely environmental (custom counters file, version mismatch, or GPU/driver not reporting). Recommend a separate issue with version + hardware details to investigate.