Added Converters for Basic Casting Operations#607
Open
JWLee89 wants to merge 10 commits into
Open
Conversation
Author
|
Hi @jaybdub, I was wondering if there are any possible potential issues with this PR? P.S. Apologies for the ping. I know that you are busy. Thank you very much for taking time out of your schedule to take a look at this. Best regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for the following casting operations under the
converters/cast.py..float(). e.gx.float().int(). e.gx.int().bool(). e.gx.bool()Tests are included along with the converters (see attached image below).
Note:
.long()is not included as this is a 64 bit data type and TensorRT does not support 64 bit data types.Test Outputs
Verified that the one
NUM_FAILED_CONVERSIONis unrelated to the added code by commenting outfrom .cast import *in__init__.pyand re-running tests.Test environment
PyTorch version: 1.8.0+cu111
Cuda: 11.1
TensorRT Version: 7.2.2.1
GPU: GeForce RTX 3090
Ubuntu version: Ubuntu 18.04.5 LTS