cast key to NSString & idea/extension for JSContext subscript access#510
Open
jasonm23 wants to merge 1 commit intoNSHipster:masterfrom
Open
cast key to NSString & idea/extension for JSContext subscript access#510jasonm23 wants to merge 1 commit intoNSHipster:masterfrom
jasonm23 wants to merge 1 commit intoNSHipster:masterfrom
Conversation
mattt
force-pushed
the
master
branch
4 times, most recently
from
1fc06e7 to
95d3aa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the first key access using a swift string, which throws a less than helpful compiler error about NSCopying etc.
Added a helper extension (and linked to origin, my OC) to give JSContext subscript access.