Recompute the resign timer when policy changes.#646
Open
Philip-NLnetLabs wants to merge 1 commit into
Open
Conversation
ximon18
reviewed
May 11, 2026
| // Just recompute the resign timer. In the future we may want to | ||
| // react to changes in policy, for example, whether NSEC is used | ||
| // or NSEC3. | ||
| let _ = self.next_resign_time_tx.send(Some(Instant::now())); |
Member
There was a problem hiding this comment.
When I read "recompute" I expected something more than "now". Is that correct?
Member
There was a problem hiding this comment.
Would some policy changes require notifying dnst keyset of changes? If so, would that result in dnst keyset deciding re-signing needs to happen now, and thus is an alternative way to do this be to nudge the Cascade key manager to invoke dnst keyset to find out if re-signing is needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recompute the resign timer when policy changes.
Cargo.*,crates/,etc/,integration-tests/,src/):actthrough theact-wrapper(as described inTESTING.md)?