Reduce git conflicts and verbose test definitions.#574
Draft
ximon18 wants to merge 3 commits into
Draft
Conversation
Combine the almost identical system test definitions into a single job that invokes them as a matrix requiring only that new test names be added to the 'tests' matrix key rather than duplicating the entire job block every time, and each PR that adds a system test then conflicting with the others due to each modifying the same part of system-tests.yml. Adds a note in act-wrapper that to limit which tests are run by the new tests job one must now supply --matrix tests:<TEST NAME TO RUN> instead of --job <JOB NAME TO RUN>..
Member
That will still be the case. Now, conflicting in modifying the same matrix definition. There is no way to avoid that conflict other than not all adding to the bottom, but some adding in between other tests (which requires them to be their own blocks instead of a matrix value). |
Member
Author
|
True but it's much less irritating to resolve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combine the almost identical system test definitions into a single job that invokes them as a matrix requiring only that new test names be added to the 'tests' matrix key rather than duplicating the entire job block every time, and each PR that adds a system test then conflicting with the others due to each modifying the same part of system-tests.yml.
Notes added to
act-wrapperhelp output:The tests fail when run, not sure if that also happens on
mainat present.Cargo.*,crates/,etc/,integration-tests/,src/):actthrough theact-wrapper(as described inTESTING.md)?