Test loading of a signed zone with a CNAME at the apex. (resolves #427)#558
Open
ximon18 wants to merge 4 commits into
Open
Test loading of a signed zone with a CNAME at the apex. (resolves #427)#558ximon18 wants to merge 4 commits into
ximon18 wants to merge 4 commits into
Conversation
The old zone loader / apex zone code couldn't handle this.
By using a pre-signed zone as input.
| @@ -0,0 +1,14 @@ | |||
| example.test. 5 IN SOA ns1.example.test. mail.example.test. 2026033000 60 60 3600 5 | |||
Member
There was a problem hiding this comment.
I wonder if we should have a setup for these tests where the input zone and the output zone are the same. It needs storing some keys somewhere, a policy with Keep, and faketime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old zone loader / apex zone code couldn't handle this case as it was not able to store a CNAME plus another record at the apex as it was not designed for DNSSEC which adds an RRSIG at the same label as the apex CNAME.
This PR loads and re-signs a pre-signed zone that contains a CNAME and RRSIG immediately below the apex
Cargo.*,crates/,etc/,integration-tests/,src/):actthrough theact-wrapper(as described inTESTING.md)?