Skip to content

完善Reaction相关实现 #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrXiaoM merged 3 commits into from
Feb 11, 2026
Merged

完善Reaction相关实现 #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17e610b
MessageReactionEvent add toString override
xiaoyv404 Feb 11, 2026
d9c5653
新版本 Onebot LLOnebot EmojiLikeNotice 存在 is_add 字段
xiaoyv404 Feb 11, 2026
fc8db64
fix typo
MrXiaoM Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion overflow-core-api/src/main/kotlin/top/mrxiaom/overflow/event/MessageReactionEvent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,6 @@ public class MessageReactionEvent(
* `true` 为添加，`false` 为移除
*/
public val operation: Boolean,
): BotEvent, AbstractEvent()
): BotEvent, AbstractEvent(){
public override fun toString()= "MessageReactionEvent(bot=$bot, group=$group, operator=$operator, messageId=$messageId, reaction='$reaction', count=$count, operation=$operation)"
}
Comment on lines +40 to +42
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toString 的实现与本仓库其他事件类的风格不一致：缺少 : String 返回类型标注、=/{ 前后的空格，以及当前输出直接拼接了 bot/group/operator 对象本身而不是更稳定的标识（仓库内常用 bot.id、group.id、operator.id 这类字段，见 MemberEssenceNoticeEvent.toString 等）。建议按现有事件的写法统一格式并优先输出 ID，避免日志过长/不稳定。

Copilot uses AI. Check for mistakes.
2 changes: 2 additions & 0 deletions ...re/src/main/kotlin/cn/evolvefield/onebot/sdk/event/notice/misc/GroupMsgEmojiLikeNotice.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ class GroupMsgEmojiLikeNotice : NoticeEvent() {
var messageId = 0
@SerializedName("likes")
var likes = LinkedList<Like>()
@SerializedName("is_add")
var isAdd: Boolean? = null

class Like {
@SerializedName("emoji_id")
Expand Down
9 changes: 7 additions & 2 deletions overflow-core/src/main/kotlin/top/mrxiaom/overflow/internal/listener/group.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,12 @@ internal fun addGroupListeners() {
val group = bot.group(e.groupId)
val member = group.queryMember(e.userId) ?: return@listen
val operator = if (member.id == bot.id) null else member
// TODO: 接口中没有提及是添加还是删除，可能要开一张缓存表来记录
val isAdd = if (e.isAdd == null) {
logger.warning("请更新至新版 NapCat 或 LLOnebot")
true
} else {
e.isAdd!!
Comment on lines +433 to +437
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里 else 分支对 e.isAdd 使用了 !!，在你已经判空后属于不必要的非空断言，后续如果逻辑改动更容易引入 NPE。建议改成直接使用 e.isAdd（或用 Elvis/?: 结构统一写法）来避免 !!。

Suggested change
val isAdd = if (e.isAdd == null) {
logger.warning("请更新至新版 NapCat 或 LLOnebot")
true
} else {
e.isAdd!!
val isAdd = e.isAdd ?: run {
logger.warning("请更新至新版 NapCat 或 LLOnebot")
true

Copilot uses AI. Check for mistakes.
}
for (like in e.likes) {
bot.eventDispatcher.broadcastAsync(MessageReactionEvent(
bot = bot,
Expand All @@ -439,7 +444,7 @@ internal fun addGroupListeners() {
operator = operator,
reaction = like.emojiId,
count = like.count,
operation = true, // TODO
operation = isAdd
))
}
}
Expand Down