Skip to content

Adds ignore_metadata option to assert_approx_df_equality #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
donielix wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adds ignore_metadata option to assert_approx_df_equality #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions chispa/dataframe_comparer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def are_dfs_equal(df1, df2):


def assert_approx_df_equality(df1, df2, precision, ignore_nullable=False, transforms=None, allow_nan_equality=False,
ignore_column_order=False, ignore_row_order=False, formats=DefaultFormats()):
ignore_column_order=False, ignore_row_order=False, ignore_metadata=False, formats=DefaultFormats()):
if transforms is None:
transforms = []
if ignore_column_order:
Expand All @@ -47,7 +47,7 @@ def assert_approx_df_equality(df1, df2, precision, ignore_nullable=False, transf
transforms.append(lambda df: df.sort(df.columns))
df1 = reduce(lambda acc, fn: fn(acc), transforms, df1)
df2 = reduce(lambda acc, fn: fn(acc), transforms, df2)
assert_schema_equality(df1.schema, df2.schema, ignore_nullable)
assert_schema_equality(df1.schema, df2.schema, ignore_nullable=ignore_nullable, ignore_metadata=ignore_metadata)
if precision != 0:
assert_generic_rows_equality(df1.collect(), df2.collect(), are_rows_approx_equal, [precision, allow_nan_equality], formats)
elif allow_nan_equality:
Expand Down