Conversation
1ce7f27 to
c515179
Compare
|
I need to find a way to run |
c515179 to
ddfcd1a
Compare
jgraham
left a comment
There was a problem hiding this comment.
I mainly reviewed the backend changes so far; for the frontend I wonder if we can get away without having this feature in the first instance.
e0f083e to
3ed40e0
Compare
| ) | ||
|
|
||
| def handle(self, *args: object, **options: object) -> None: | ||
| status = ClusteringJob.get_clustering_status() |
There was a problem hiding this comment.
How important is this lock if we can't run stuff from the UI? I guess it still makes sense, but it also makes sense that we can't run multiple import jobs in parallel for example, in which case maybe we should have a more generic locking mechanism rather than one specific to this job type? I guess we're also using it to track progress, but again it seems like there's a lot in common with what we'd want to track progress of other jobs e.g. import. Not a change for this PR.
There was a problem hiding this comment.
Yeah, triage_new_reports runs every hour, so it's unlikely (but possible) that it will run at the same time as full reclustering (which I'm thinking to run with a command directly). Also on the first run triage_new_reports checks whether there are any successful runs, i.e. initial clustering exists and returns early if not. I guess it could also trigger initial clustering once (if it doesn't exist) without me manually running the command.
But yes I agree about generic locking mechanism.
7c219b9 to
884f346
Compare
jgraham
left a comment
There was a problem hiding this comment.
I think we should land this (once the lint is fixed!) so we can start to see the results and experiment with it.
884f346 to
99e3155
Compare
99e3155 to
7bb6c35
Compare

Changes in this PR:
import_reports_from_bigqueryis only saving reports to db without cluster_id or bucket_idtriage_new_reportscommand gets reports that don't have bucket_id and attempts to cluster and bucket them (runs every hour at the moment)I think once we import live reports the frequency of triaging can be increased.