GEOPY-2910: reverting changes - introduced slowness#159
Closed
sebhmg wants to merge 2 commits into
Closed
Conversation
…te_release" This reverts commit f93e8b3.
Author
|
oops, wrong branch name |
There was a problem hiding this comment.
Pull request overview
This PR aims to revert and adjust recent sensitivity/Jacobian assembly changes in the Dask TDEM simulation that introduced performance regressions, primarily by changing how field-derivative blocks are accumulated and processed.
Changes:
- Restores default
get_parallel_blocksbehavior by removing the explicitoptimize=Falseoverride. - Refactors
get_field_deriv_blockto operate on per-chunkATinvderivative arrays (list-of-arrays) instead of a single concatenated matrix, and updatescompute_rowsto match. - Wires a
clientargument through the field-derivative block computation path (currently unused in the helper).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
167
to
170
| for block_ind in range(len(blocks)): | ||
|
|
||
| if len(blocks[block_ind]) == 0: | ||
| if len(block) == 0: | ||
| continue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2910 - Reduce chunking of sensitivities for TEM inversions