Skip to content

Draft: Make fof compare work with radar fof files #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
muellch wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

Draft: Make fof compare work with radar fof files #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions util/fof_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def get_report_variables(ds):
Get variable names of reports.
"""
vars_shape_report = []
shape_report = ds.attrs["n_hdr"]
shape_report = ds["d_hdr"].size

for var in ds.data_vars:
if ds[var].shape[0] == shape_report:
Expand All @@ -30,7 +30,7 @@ def get_observation_variables(ds):
Get variable names of observations.
"""
vars_shape_observation = []
shape_observation = ds.attrs["n_body"]
shape_observation = ds["d_body"].size

for var in ds.data_vars:
if ds[var].shape[0] == shape_observation:
Expand All @@ -52,9 +52,12 @@ def split_feedback_dataset(ds):
ds_report_sorted = ds_reports.sortby(sort_keys_reports)

lbody = ds["l_body"].values
nbody = ds.attrs["n_body"]
dbody = ds["d_body"].size

for varname in filter(lambda s: s in ["lat", "lon", "statid", "time_nomi"], ds):
values = np.repeat(ds[varname], lbody.astype(int))
values = np.append(values, np.zeros(dbody - nbody))
Copy link
Copy Markdown
Author

@muellch muellch May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fill with zeroes? Make the array shorter? Fill with nan?

attrs = ds[varname].attrs
ds = ds.assign({varname: xr.Variable("d_body", values, attrs=attrs)})

Expand All @@ -65,6 +68,7 @@ def split_feedback_dataset(ds):

ds_obs = ds[observation_variables]
sort_keys_obs = ["lat", "lon", "statid", "varno", "level", "time_nomi"]
#sort_keys_obs = ["dlat", "dlon", "statid", "varno", "level", "time_nomi"] # this can be added at a later stage together with if RADAR statement somewhere
ds_obs_sorted = ds_obs.sortby(sort_keys_obs)

return ds_report_sorted, ds_obs_sorted
Expand Down