Closed
Conversation
Bumps thirdparty/mrbind 2978653c → b082633a (6 commits ahead). 63534a8f Python: Allow enabling `const_cast` for returned const references. 063dc2e1 More readme tweaks. 124a84e2 C#: When adjusting parameter names matching keywords, also adjust those names in the function comment if any. 4342e419 Fix the SFINAE trap on functions not working on Clang 22. c511bccc Remove our pybind target headers from gitignore. They were already committed, but also ignored for no reason. b082633a Python: Spell `*` as `ptr` when converting C++ names to Python style, instead of ignoring this symbol.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump the
thirdparty/mrbindsubmodule pointer from2978653cto itsmasterHEADb082633a(compare). Six commits ahead of where MeshLib currently pins:63534a8fconst_castfor returned const references.063dc2e1124a84e24342e419c511bcccb082633a*asptrwhen converting C++ names to Python style, instead of ignoring this symbol.The same two bumps were already applied (and merged via the embedded "Update mrbind." / "Hopefully fix ambiguous Python names." commits) on the in-flight #6021 / #6060 branches. This PR re-lands them on a clean branch off master so the submodule pointer can be updated independently of those CI-rework PRs.
Test plan
*→ptrname mapping change, all of which can affect generated bindings.