Conversation
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 🤖 Continuous IntegrationWaiting for
This rule is failing.
🔴 👀 Review RequirementsWaiting for
This rule is failing.
🔴 🔎 ReviewsWaiting for
This rule is failing.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
There was a problem hiding this comment.
Pull request overview
Updates the Enterprise “Advanced Features” documentation to emphasize using cloud-native identity/credential discovery (ADC on GCP, IAM role-based discovery on AWS) for CI traces object storage, reducing reliance on long-lived static keys and manual rotation.
Changes:
- Reordered GCS auth options to lead with Application Default Credentials (recommended), moving JSON key usage to a secondary option.
- Reworked S3 auth guidance to lead with IAM role discovery (recommended), moving access-key details (and related notes) into the access-key option.
- Adjusted the introduction copy to present workload-identity discovery as the primary mode across providers.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…rage Lead with IAM role discovery / Application Default Credentials in both the S3 and GCS sections so self-hosted operators land on the path that avoids manual key rotation. Move AWS_ACCOUNT_ID/AWS_REGION and the MERGIFYENGINE_AWS_* deprecation note into the access-key option, since neither is needed when boto3 resolves credentials from the workload. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Change-Id: Idb1bb865a7b671c6e002eeeffb4f322f11dadb6c
sileht
force-pushed
the
devs/sileht/onpremise-iam-role/recommend-cloud-workload-identity-ci-traces--db1bb865
branch
from
7aa7ddf to
450013c
Compare
Member
Author
Revision history
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lead with IAM role discovery / Application Default Credentials in both the
S3 and GCS sections so self-hosted operators land on the path that avoids
manual key rotation. Move AWS_ACCOUNT_ID/AWS_REGION and the
MERGIFYENGINE_AWS_* deprecation note into the access-key option, since
neither is needed when boto3 resolves credentials from the workload.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com