Skip to content
This repository was archived by the owner on Jun 30, 2021. It is now read-only.

Single-parameter constructors should be marked explicit. #62

Open
mamil wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Single-parameter constructors should be marked explicit. #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c00d410
Single-parameter constructors should be marked explicit.
mamil Sep 22, 2019
b308a04
No newline at end of file
mamil Sep 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/served/multiplexer.test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class path_collecting_functor
{
request_router_story & _story_obj;
public:
path_collecting_functor(request_router_story & story_obj)
explicit path_collecting_functor(request_router_story & story_obj)
Copy link
Copy Markdown

@shlomnissan shlomnissan Jul 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

: _story_obj(story_obj) {}

void operator()(served::response & response, const served::request & request)
Expand Down
2 changes: 1 addition & 1 deletion src/served/status.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@
* SOFTWARE.
*/

#include <served/status.hpp>
#include <served/status.hpp>
Copy link
Copy Markdown

@shlomnissan shlomnissan Jul 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was anything changed? I don't think this line should be committed

Copy link
Copy Markdown
Author

@mamil mamil Jul 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to have a newline at end of file