This repository was archived by the owner on Jun 30, 2021. It is now read-only.
[WIP] Stability: Add stability test example and start multithreaded fixes#53
Open
AdrianDC wants to merge 3 commits into
Open
[WIP] Stability: Add stability test example and start multithreaded fixes#53AdrianDC wants to merge 3 commits into
AdrianDC wants to merge 3 commits into
Conversation
AdrianDC
force-pushed
the
master
branch
2 times, most recently
from
64a9c5b to
cafe440
Compare
* Test sequence: - mkdir ./served.build/ - cd ./served.build/ - cmake -DCMAKE_BUILD_TYPE=Debug -DSERVED_BUILD_SHARED=ON -DSERVED_BUILD_STATIC=ON -DSERVED_BUILD_EXAMPLES=ON -DSERVED_BUILD_RPM=ON ../served/ - make -j8 - ../served/bin/eg_stability - gdb -q --batch -ex 'set print thread-events off' -ex 'run' -ex 'bt' ../served/bin/eg_stability
* A class destructor is added to properly release the members * The threads are joined upon destruction to ensure work is done * A 1 millisecond delay is added to avoid multithreading races * Threads are create with "bind" references rather than lambdas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Served server generates random segmentation faults (SIGSEGV) upon cleanups,
due to race conditions throughout the Boost ASIO io_service destructors.
The issue can be proven with the new "stability" example sources,
iterating through 1000 creations of
served::net::serverwith explicitstop()callsand through 1000 creations of
served::net::serverwithout callingstop().