Skip to content

Fix and clean the tests project and add run_test_projects.yml#459

Open
charlesroddie wants to merge 19 commits intoMediaPortal:masterfrom
charlesroddie:FixTestBuildAndRunner
Open

Fix and clean the tests project and add run_test_projects.yml#459
charlesroddie wants to merge 19 commits intoMediaPortal:masterfrom
charlesroddie:FixTestBuildAndRunner

Conversation

@charlesroddie
Copy link
Copy Markdown

@charlesroddie charlesroddie commented Mar 24, 2026

  • Fixes NuGet.Config, adding nuget.org as a package source. Previously only the MyGet feed was configured, causing restore failures for packages not hosted there. Also fixes the MyGet link and routes UndecodeSharpFork explicitly to Myget.
  • Fixes and cleans the MediaPortal.Tests project setup so it builds and runs in visual studio.
    • Migrated from NUnit 2 to NUnit 3.
    • Removed all the checked in binaries and other extraneous artifacts, referencing properly from Nuget.
  • Adds a new GitHub Actions workflow to run the tests. NB this is not tested: I believe on github you have to merge a new yml file before you can run it.
  • For the failing tests, fixes most of them, deletes one which is nonsensical, and ignores the remaining ones with a comment.

@github-actions github-actions bot added the bug label Mar 24, 2026
@github-actions github-actions bot added this to the 1.39 Final milestone Mar 24, 2026
@charlesroddie charlesroddie marked this pull request as ready for review March 24, 2026 05:05
@andrewjswan
Copy link
Copy Markdown
Member

Test build - CI AppVeyyor - Failed

@doskabouter
Copy link
Copy Markdown
Contributor

I agree with all remarks of andrew

@doskabouter
Copy link
Copy Markdown
Contributor

Can you at least revert the lines that appear as changed? Mostly first and last lines of the file. Don't exactly know what changed that makes git think it's changed, but it's distracting at the very least

@github-actions github-actions bot removed the large label Mar 29, 2026
@charlesroddie
Copy link
Copy Markdown
Author

Can you at least revert the lines that appear as changed? Mostly first and last lines of the file. Don't exactly know what changed that makes git think it's changed, but it's distracting at the very least

done

@charlesroddie
Copy link
Copy Markdown
Author

AppVeyor build failed

This is private when I click the link, so if this failure is related to this PR and you'd like me to look into it, you'll need to pass on the info or give me access or make this public. @andrewjswan @doskabouter

@doskabouter
Copy link
Copy Markdown
Contributor

AppVeyor build failed

This is private when I click the link, so if this failure is related to this PR and you'd like me to look into it, you'll need to pass on the info or give me access or make this public. @andrewjswan @doskabouter

private? appveyor is public: https://ci.appveyor.com/project/MediaPortal/mediaportal-1

@github-actions github-actions bot added large and removed medium labels Mar 29, 2026
@charlesroddie
Copy link
Copy Markdown
Author

OK thanks. I see them now. Perhaps I clicked on the wrong link before.

Trying to fix appveyor now.

I believe when this is done you can remove these packages from MyGet as they exist on Nuget with the same versions:

CSCore 1.2.1.2
FFmpeg.Win32.Static 4.1.1.1
FFmpeg.Win64.Static 4.1.1.1
HtmlAgilityPack 1.11.46
MediaInfo.Native 21.9.1
MediaInfo.Wrapper 21.9.2
MediaInfo.Wrapper 21.9.3
MediaPortal-iMON-Display 1.1.0
MetadataExtractor 2.8.0
NAudio 1.10.0
Newtonsoft.Json 13.0.3
NUnit 3.14.0
NUnit3TestAdapter 4.6.0
SharpDX 4.2.0
SharpDX.Direct3D9 4.2.0
SharpDX.DirectInput 4.2.0
SharpDX.Mathematics 4.2.0
SharpDX.RawInput 4.2.0
SharpLibDisplay 0.3.4
SharpLibHid 1.5.1
SharpLibWin32 0.2.1
System.Management.Automation 6.1.7601.17515
System.ValueTuple 4.5.0
XmpCore 6.1.10.1

@andrewjswan
Copy link
Copy Markdown
Member

you can remove these packages from MyGet

Why? What's the point?
We can't completely stop using MyGet, so there's no point in removing anything. Especially since MyGet proxies NuGet.

<Message Text="Found the following 'packages.config'-files: @(PackagesConfigs->'%(FullPath)')"/>
<Message Text="Found the following 'packages.config'-files: @(PackagesConfigs->'%(FullPath)')"/>

<Exec Command='"$(NuGetExePath)" install "%(PackagesConfigs.FullPath)" -Source "https://www.myget.org/F/mediaportal/"'/>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand this change — why remove MyGet?

</packageRestore>
<packageSources>
<add key="TeamMediaPortal source @ MyGet" value="https://www.myget.org/F/mediaportal/" />
<add key="nuget.org" value="https://api.nuget.org/v3/index.json" protocolVersion="3" />
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MyGet proxies NuGet packages, and it’s enabled by default in Visual Studio, so I think it’s unnecessary. Especially since we sometimes freeze versions on MyGet that disappear from NuGet because the author has decided to move on and no longer support older frameworks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants