Fix and clean the tests project and add run_test_projects.yml#459
Fix and clean the tests project and add run_test_projects.yml#459charlesroddie wants to merge 19 commits intoMediaPortal:masterfrom
Conversation
|
Test build - CI AppVeyyor - Failed |
|
I agree with all remarks of andrew |
…to the myget source and a fix to the myget link
…rying to commit changes.")
|
Can you at least revert the lines that appear as changed? Mostly first and last lines of the file. Don't exactly know what changed that makes git think it's changed, but it's distracting at the very least |
done |
This is private when I click the link, so if this failure is related to this PR and you'd like me to look into it, you'll need to pass on the info or give me access or make this public. @andrewjswan @doskabouter |
private? appveyor is public: https://ci.appveyor.com/project/MediaPortal/mediaportal-1 |
|
OK thanks. I see them now. Perhaps I clicked on the wrong link before. Trying to fix appveyor now. I believe when this is done you can remove these packages from MyGet as they exist on Nuget with the same versions: |
Why? What's the point? |
| <Message Text="Found the following 'packages.config'-files: @(PackagesConfigs->'%(FullPath)')"/> | ||
| <Message Text="Found the following 'packages.config'-files: @(PackagesConfigs->'%(FullPath)')"/> | ||
|
|
||
| <Exec Command='"$(NuGetExePath)" install "%(PackagesConfigs.FullPath)" -Source "https://www.myget.org/F/mediaportal/"'/> |
There was a problem hiding this comment.
I don't quite understand this change — why remove MyGet?
| </packageRestore> | ||
| <packageSources> | ||
| <add key="TeamMediaPortal source @ MyGet" value="https://www.myget.org/F/mediaportal/" /> | ||
| <add key="nuget.org" value="https://api.nuget.org/v3/index.json" protocolVersion="3" /> |
There was a problem hiding this comment.
MyGet proxies NuGet packages, and it’s enabled by default in Visual Studio, so I think it’s unnecessary. Especially since we sometimes freeze versions on MyGet that disappear from NuGet because the author has decided to move on and no longer support older frameworks.
NuGet.Config, addingnuget.orgas a package source. Previously only the MyGet feed was configured, causing restore failures for packages not hosted there. Also fixes the MyGet link and routes UndecodeSharpFork explicitly to Myget.MediaPortal.Testsproject setup so it builds and runs in visual studio.