Add grabber script tests and get some working#458
Draft
charlesroddie wants to merge 11 commits intoMediaPortal:masterfrom
Draft
Add grabber script tests and get some working#458charlesroddie wants to merge 11 commits intoMediaPortal:masterfrom
charlesroddie wants to merge 11 commits intoMediaPortal:masterfrom
Conversation
andrewjswan
requested changes
Mar 24, 2026
| if (!string.IsNullOrEmpty(apers.Name)) | ||
| { | ||
| if (apers.As.Contains("Direct") && string.IsNullOrEmpty(sDirector)) | ||
| if (apers.As == "Director" && string.IsNullOrEmpty(sDirector)) |
| aPerson.Id = crew.id.ToString(); | ||
| aPerson.Name = crew.name; | ||
| aPerson.As = crew.department; // crew.job; | ||
| aPerson.As = crew.job; |
Member
There was a problem hiding this comment.
As far as I recall, the data in the “department” field is more accurate than that in the “job” field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DONE:
TODO: script fixes.
I will fix the TI_MDB one and get it to accept the
[tt...]format like other scripts. I will see if others can be improved, but I expect that most will remain non-functional. I suggest they are archived but it's up to maintainers.STATUS:
Fixed tests:
FindFilm_ReturnsResults("TI_MDB","The Shawshank Redemption (1994) [tt0111161]","The Shawshank Redemption (1994)"). Regex fix allowing imdbid in square brackets.GetDetails_ReturnsCorrectData("TI_MDB","The Shawshank Redemption (1994) tt0111161"). Fix to theDirectorlookup.Failing tests:
