Skip to content

Fix default angled camera orientation in ThreeDScene #4704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
siddhu-pikachu wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −3
Open

Fix default angled camera orientation in ThreeDScene #4704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions manim/scene/three_d_scene.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,8 +428,8 @@ def set_to_default_angled_camera_orientation(self, **kwargs):
which have the same meaning as the parameters in set_camera_orientation.
"""
config = dict(
self.default_camera_orientation_kwargs,
) # Where doe this come from?
self.default_angled_camera_orientation_kwargs,
)
config.update(kwargs)
self.set_camera_orientation(**config)

Expand Down
11 changes: 10 additions & 1 deletion tests/module/scene/test_threed_scene.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from manim import Circle, Square, ThreeDScene
from manim import DEGREES, Circle, Square, ThreeDScene


def test_fixed_mobjects():
Expand All @@ -15,3 +15,12 @@ def test_fixed_mobjects():
assert set(scene.camera.fixed_orientation_mobjects) == {s}
scene.remove_fixed_orientation_mobjects(s)
assert len(scene.camera.fixed_orientation_mobjects) == 0


def test_set_to_default_angled_camera_orientation():
scene = ThreeDScene()

scene.set_to_default_angled_camera_orientation(phi=45 * DEGREES)

assert scene.camera.get_phi() == 45 * DEGREES
assert scene.camera.get_theta() == -135 * DEGREES
Loading